Clojurians Log v2

I think it could

Would an issue for this be welcome?

I'm looking at this now. When I print the types that are coming into double I'm getting this:

$ clj -M:clj-kondo/dev --lint - <<< '(defn foo ^double [] 1.0) (double (foo))'
:tags (#{:double :int :float})
linting took 38ms, errors: 0, warnings: 0

probably type inference adds more stuff than is reported by the return tag

sure issue welcome

I added this to lint-arg-types! just to give you an idea:

(when (and
             (= 'double (:name called-fn))
             (utils/one-of (:ns called-fn) [clojure.core cljs.core])
             )
        (prn :tags tags)
        (findings/reg-finding! ctx
                               (assoc (select-keys call [:row :end-row :col :end-col :filename])
                                      :type :equals-float
                                      :message "Equality comparison of floating point numbers")))

#{:double :float :int} is coming from tag-from-meta. It looks like the double, float, Double and Float cases should be tightened up. I’ll explore.

nice

It looks like tightening tag-from-meta will work with additional is-a-relations and could-be-relations changes: https://github.com/hugoduncan/clj-kondo/commit/f881e08d924f2ab8cecdb4fbe72b1c9ece78ddf1

awesome!

It doesn’t help that clojure type coercion functions don’t type hint their return values (this doesn’t cause problems when using the functions, because of the :inline meta, and because calling as a function object is going to return an object anyway).

we can override this in types/clojure/core.clj