Clojurians Log v2

; echo '(ns foo (:require bar clojure.template)) (clojure.template/do-template [x] (do x #bar/a "aaa") (bar/b "bbb"))' | clj-kondo --config '{:linters {:discouraged-var {clojure.core/read-string {}}} :hooks {:macroexpand {clojure.template/do-template clojure.template/do-template}}}' --lint -
<stdin>:1:96: warning: Discouraged var: clojure.core/read-string
linting took 86ms, errors: 0, warnings: 1

here are the contents a bit more readable

(ns foo (:require bar clojure.template))

(clojure.template/do-template
 [x]
 (do x #bar/a "aaa")
 (bar/b "bbb"))

{:linters
 {:discouraged-var {clojure.core/read-string {}}}
 :hooks
 {:macroexpand {clojure.template/do-template clojure.template/do-template}}}

do-template doesn't contain any read-strings as far as I can tell and the rest are made up

I don't think this is related to do-template at all but something in rewrite-clj

user=> (rewrite-clj.node/sexpr (p/parse-string "#bar/x []"))
(read-string "#bar/x []")

ah

feel free to report this (small repro I posted is fine) as a false positive with discouraged-var

in combination with a macro expand hook

since that uses sexpr internally

gotcha, thank you

this should help reducing it even further

I'll submit an issue

https://github.com/clj-kondo/clj-kondo/issues/2466

Thank you!

I tried but haven't been able to repro the old behavior even going back several months. Concluded that the hook must be incorrect and since it was also quite limited, I ended up rewriting it. Works well now 🙂

Of course it's possible that our hook does something fishy

Not sure how much of the hook code I can share, but there's one part that alters a node adding some metadata to parts of it:

(vary-meta expected-fn assoc :clj-kondo/ignore [:unresolved-symbol])

could be one of the commits on dec. 3

not sure of course, but worth a try

thanks I'll try to check that out