2024-12-30 clj-kondo | Clojure Slack Archive

clj-kondo 2024-12-30

Ovi Stoica 2024-12-30T10:55:59.055529Z

Hello, am I doing something wrong with this hook? I have this macro:

(ns voice-fn.frames)

(defmacro defframe
  "Define a frame creator function and its predicate.
   Usage: (defframe audio-input :audio/raw-input \"Doc string\")"
  [name type docstring]
  `(do
     (defn ~name
       ~docstring
       [data#]
       (create-frame ~type data#))

     (defn ~(symbol (str name "?"))
       [frame#]
       (and (frame? frame#) (= ~type (:frame/type frame#))))))

(defframe llm-output-text-sentence-frame :llm/output-text-sentence
  "Frame generated by a sentence assembler that takes in chunks from a LLM processor")

.clj-kondo/config.edn:

{:lint-as {uncomplicate.commons.core/with-release clojure.core/let}
 :hooks {:analyze-call {voice-fn.frames/defframe hooks.defframe/defframe}}}

.clj-kondo/hooks/defframe.clj

(ns hooks.defframe
  (:require
   [clj-kondo.hooks-api :as api]))

(defn defframe [{:keys [node]}]
  (let [[name _type docstring] (rest (:children node))
        frame-name (api/token-node (api/symbol-from-node name))
        pred-name (api/token-node (symbol (str (api/symbol-from-node name) "?")))]
    {:node (api/list-node
             [(api/token-node 'do)
              (api/list-node
                [(api/token-node 'defn) frame-name docstring])
              (api/list-node
                [(api/token-node 'defn) pred-name])])}))

I am using clj-kondo through clojure LSP, so it might be that issue but it feels I just might be doing something wrong

borkdude 2024-12-30T10:59:00.291089Z

You can be more specific what you mean with "wrong"? What is e.g. the expected behavior and the behavior you are now seeing?

Ovi Stoica 2024-12-30T11:00:04.142649Z

Sorry, yeah, the expected behaviour is clojure-lsp will pick this config but I still get

borkdude 2024-12-30T11:04:49.258559Z

try linting from the command line first

👍 1

Ovi Stoica 2024-12-30T11:04:49.875699Z

Some relevant other details: • I restarted lsp-mode to make sure the new config is taken into account • My file structure might be relevant

voice-fn/
  .clj-kondo/
  core/
      .clj-kondo //specific to core
      src/
  examples

To make sure that this would work I included this config in both clj-kondo configs to be sure

borkdude 2024-12-30T11:05:12.183049Z

just with clj-kondo, no lsp

borkdude 2024-12-30T11:05:34.459879Z

you can't have multiple .clj-kondo directories in one project

Ovi Stoica 2024-12-30T11:06:10.846499Z

I see. So best I move all config to topmost directory

borkdude 2024-12-30T11:06:25.479059Z

yes or make multiple projects

Ovi Stoica 2024-12-30T11:15:53.135649Z

Is a project defined by the presence of a deps.edn file or of a git repository? I have 2 deps.edn projects (core & examples) in the same git repo

borkdude 2024-12-30T11:18:18.410349Z

deps.edn

Ovi Stoica 2024-12-30T11:18:24.146679Z

The issue is picked up by kondo itself too, with latest release version

borkdude 2024-12-30T11:18:51.563369Z

well, you see the WARNING? that is the issue you should address

Ovi Stoica 2024-12-30T11:19:13.368469Z

Thank you, I saw it now after posting 😄

😀 1

Eric Dvorsak 2024-12-30T12:12:08.035609Z

I'm wondering if this is something clj-kondo could lint, it is not the first time I see a bug introduced in a project by someone putting an s-expression in the :or default value of a destructuring: https://github.com/cognitect-labs/aws-api/issues/262

user> (defn f1 [] (println "WOW YOU DON'T WANT THIS TO RUN"))
#'user/f1
user> (let [{:keys [x] :or {x (f1)}} {:x 1}] x)
WOW YOU DON'T WANT THIS TO RUN
1

borkdude 2024-12-30T14:37:16.625569Z

I think that's a reasonable thing to want. Issue welcome!

Eric Dvorsak 2024-12-31T11:09:57.009739Z

done

Clojurians Log v2

clj-kondo 2024-12-30