Clojurians Log v2

I generally commit them. I only ignore .clj-kondo/.cache but I suspect some people ignore them. They are imported configurations of libraries you use, so that clj-kondo understands them better.

(they should only change when your dependencies change, and that would be committed so I consider it part of "library version changes")

Makes sense, thank you!

yeah, I also commit them

oh, looks like it's not quite the same problem. The second test case from that issue doesn't produce an error, yet if I tweak it slightly then it does

;; no warnings
(defn fun2 [^String replacement]
  (str/replace "foo" #"foo" replacement))

;; error: String match arg requires string replacement arg
(defn fun2 [^String replacement]
  (str/replace "foo" "foo" replacement))

interestingly, if I type hint my own example as (let [z ^String "z"] then the error goes away

that isn't valid clojure code though

user=> ^String "foo"
Syntax error reading source at (REPL:1:14).
Metadata can only be applied to IMetas
user=> 

you're right, I should have written something like (let [z ^String (str "z")]

which also makes the linting error go away

@mgardner2 thanks, this seems to be a false positive:

(let [^String z "z"]
  (clojure.string/replace "x" "y" z))

https://github.com/clj-kondo/clj-kondo/issues/2415

thank you @borkdude for the fix!

@mgardner2 no problem!