2024-09-24 clj-kondo | Clojure Slack Archive

clj-kondo 2024-09-24

cjohansen 2024-09-24T13:00:11.464429Z

How do I convert a clj-kondo.hooks-api/keyword-node? to a symbol node? In other words, what is the API's version of "(symbol (name kw))"?

cjohansen 2024-09-24T13:03:36.829439Z

(api/token-node (symbol (:string-value kw-node)))

Seems to work, but is it an ok thing to do?

dpsutton 2024-09-24T13:07:16.165369Z

(clj-kondo.hooks-api/parse-string ":foo")
#clj_kondo.impl.rewrite_clj.node.keyword.KeywordNode{:k :foo,
                                                     :namespaced? nil}

for me, keyword nodes have a :k value, not a :string-value

cjohansen 2024-09-24T13:07:33.120819Z

Yeah, I noticed

cjohansen 2024-09-24T13:07:40.986159Z

Must have tested with a string also and mixed them up

dpsutton 2024-09-24T13:07:43.171679Z

(i do see that attribute on token-nodes however)

cjohansen 2024-09-24T13:08:04.399319Z

So I ended up with (api/token-node (symbol (name (:k kw-node))))

dpsutton 2024-09-24T13:08:43.305549Z

that could drop the namespace of keywords you analyze. is that acceptable?

cjohansen 2024-09-24T13:10:58.784379Z

Yeah, it's fine for now. I am looking to transform code for clj-kondo so it recognizes something as ~a function

dpsutton 2024-09-24T13:11:23.599309Z

I’m looking at what we do in some of our custom analysis

.clj-kondo/src/hooks/metabase/api/common.clj
21:                    (api/token-node 'do)
22:                    (-> (api/token-node (symbol "compojure.core" (str (api/sexpr method))))
26:                      (api/token-node 'clojure.core/defn)
27:                      (-> (api/token-node (route-fn-name (api/sexpr method) (api/sexpr route)))

https://github.com/metabase/metabase/blob/master/.clj-kondo/src/hooks/metabase/api/common.clj#L27 We seem to prefer using api/sexp instead of using internal attributes

dpsutton 2024-09-24T13:11:36.775919Z

was aging for api/token-node

cjohansen 2024-09-24T13:13:38.959439Z

Ah, that's probably a little more resilient. Thanks

👍 1

Clojurians Log v2

clj-kondo 2024-09-24