Also a nice addition for the analysis (lsp): @inc wasn't previously recognized as a call to clojure.core/deref, now it is cc @UKFSJSM38

cool! 👏

Thanks for the update! Came back from vacation to see linting took 4652ms, errors: 972, warnings: 7 haha :face_with_hand_over_mouth: Using mount.lite with @ to deref the defstates it creates.

<@U04V15CAJ> is there an exclude option for _`:type-mismatch` ? I tried, but doesn't work. `<http://mount.li|mount.li>_te/defstate` is linted as `_clojure.core/_def` but is of type `mount.lite.State` . State is a record of protocol IState, this record also contains IDeref. You can deref it to retrieve the contents.

Example: _(*deref* db/_datasource_)_ / @db/datasource returns: _{:datasource #_object _[_com.zaxxer.hikari.HikariDataSource 0x30975b87 "HikariDataSource (HikariPool-1)"_]}_ This gets flagged by clj-kondo with: Expected: deref, received: map.clj-kondo(type-mismatch)

can you make a small repro and file an issue?

yes, you can override type mismatch:

{:linters {:type-mismatch {:namespaces {'clojure.core {'deref {:arities {1 {:args [:any]}}}}}}}}

Thanks, I will try and will make an issue with repro for you

I think the issue might have arisen from the hooks which make clj-kondo think defstate returns a map, possibly: https://github.com/aroemers/mount-lite/blob/2.x/resources/clj-kondo.exports/functionalbytes/mount-lite/hooks/lite.clj

In some cases it indeed can return a map

The point isn't what happens in reality, but what clj-kondo thinks is happening, due to those hooks

you can also try to override the type of defstate:

{:linters {:type-mismatch {:namespaces {'mount.lite {'defstate {:arities {:varargs {:ret :any}}}}}}}}

if that works, perhaps it's best to move that to mount.lite

@U02CX2V8PJN you can try the version from my PR here: https://github.com/aroemers/mount-lite/pull/31

will do, you are so fast. I was still figuring out how to create a repro

I tried both linter options, neither work

actually this is a better solution: https://github.com/aroemers/mount-lite/pull/31/commits/a1520a46c1da6195bc37a9e5b2682ee977f5dd66

linting took 5893ms, errors: 0, warnings: 0

Thanks, that worked like a charm

👍

Perhaps you can make a comment in that PR to say that it worked for you

I was just finishing typing exactly that

🙂

Maybe @U050RCD9L can merge the PR and do a release?

Had to make a quick override hook to fix the default hook resetting

yeah you could do that as well for now

yeah, good idea. issue welcome

sure gimme a few mins

there's a similar mechanism in babashka for the version comparison etc, probably that code can be borrowed/copy-pasted

in bb it's called :min-bb-version in bb.edn

yep, that's where the idea came from

https://github.com/clj-kondo/clj-kondo/issues/2362

I added a bit about detecting outdated bin from the linter names in the config

oh that's actually covered by the current linter

I wonder if that only works on the very file or the aggregate?

This would be very welcome. I was confused why a check was failing in CI when it passed locally, and it turned out to be exactly this: CI version of clj-kondo was older than my local one.

give it a 👍:skin-tone-3: so 🙂