try :lint-as {dumdom/whatever clj-kondo.lint-as/def-catch-all}

it would seem more natural to me if dumdom had written the macro like this:

(defcomponent heading
  {:on-render (fn ...)}
  [data]
  )

which is already supported by defn

I’m currently using a macro that someone wrote that “fixes” this similar to what you suggest:

(ns dumbom.dumdom.macros
  (:require [dumdom.core :as dumdom]))

(defn- extract-docstr
  [[docstr? & forms]]
  (if (string? docstr?)
    [docstr? forms]
    ["" (cons docstr? forms)]))

(defn- extract-opts
  ([[argvec ?opts & forms]]
   (assert (vector? argvec))
   (if (map? ?opts)
     [?opts (cons argvec forms)]
     [{} (list* argvec ?opts forms)])))

(defmacro defcomponent
  "A workaround to make default linting resolve `defcomponent` without complaints.

  Instead of this:
  (defcomponent Widget
      \"A Widget\"
      :on-mount #(...)
      :on-render #(...)
      [value constant-value]
      (some-child-components))

  We can write this:
  (defcomponent Widget
      [value constant-value]
      {:name \"A Widget\"
       :on-mount #(...)
       :on-render #(...)}
      (some-child-components))"
  [name & forms]
  (let [[docstr forms] (extract-docstr forms)
        [options forms] (extract-opts forms)
        [argvec & body] forms
        options (merge {:name (str (:name (:ns &env)) "/" name)} options)]
    `(def ~name ~docstr (dumdom.core/component (fn ~argvec ~@body) ~options))))

Well, it's not up to me how people write their macros but the closer you stay to existing syntax, the easier it is to get working with clj-kondo. Maybe you could bring that advice to the library author. Above I gave one solution (def-catch-all). Another is to write a hook.

The catch-all gets rid of the warnings, but it doesn’t “recognize” local bindings, afaict.

that's right, it just tries to do the best it can: see that the name defines a var and ignore all the rest in the body

The library author is writing a replacement of Dumdom that doesn’t have components. 😃

if you want to improve on that, write a hook

I’ll read up on hooks.

I gave a workshop on ClojureD 2022 on hooks ;)

I visited @U07FP7QJ0’ Minecraft workshop instead! 😃

docs: https://github.com/clj-kondo/clj-kondo/blob/master/doc/hooks.md example configs: https://github.com/clj-kondo/clj-kondo/discussions/1528

I now regret my macro design decisions 😅

Maybe dumdom could support the alternative variant as well, I think that should be doable

if you support it so that people can write: {:lint-as {dumdom/defcomponent clojure.core/defn}} that would be nice

Yeah, that’s what the macro I posted above achieves.

If you are attending the Conj this year, I will attend any workshop you host, @U04V15CAJ.

lol

Though having my kids glued to when I slayed the Ender Dragon with Clojure was totally awesome, so no regrets here!

yeah, minecraft is certainly less boring than clj-kondo hooks :)

although I've never tried it myself

I’ll return to judging that once I have this hook written. 😃

So, for this form:

(defcomponent heading
  :on-render (fn [dom-node val old-val])
  [data]
  [:h2 {:style {:background "#000"}} (:text data)])

{:node }

(defcomponent heading
  :on-render (fn [dom-node val old-val])
  'foo
  [data]
  [:h2 {:style {:background "#000"}} (:text data)])

The hook:

(ns hooks.dumdom
  (:require [clj-kondo.hooks-api :as api]))

(defn- extract-docstr
  [[docstr? & forms :as maybe-forms]]
  (if (api/string-node? docstr?)
    [(api/sexpr docstr?) forms]
    ["no docs" maybe-forms]))

(defn- extract-opts
  ([forms]
   (extract-opts forms {}))
  ([[k v & forms :as maybe-forms] opts]
   (if (api/keyword-node? k)
     (extract-opts forms (assoc opts (api/sexpr k) (api/sexpr v)))
     [opts maybe-forms])))

(defn defcomponent [{:keys [node]}]
  (println "defcomponent\n node:" node)
  (let [[name & forms] (rest (:children node))
        [docstr forms] (extract-docstr forms)
        [options forms] (extract-opts forms)
        [argvec & body] forms
        new-node (api/list-node
                  (list*
                   (api/token-node 'defn)
                   name
                   docstr
                   options
                   (api/sexpr argvec)
                   body))]
    {:node new-node}))

Try running clj-kondo with the --debug flag on the command line, it might output some helpful info

also print the new-node

clj-kondo --lint - --debug << 'EOF'
(ns dumbom.home
  (:require [dumdom.core :refer [defcomponent]]))

(defn heading "no docs" {:on-render (fn [dom-node val old-val])} [data] [:h2 {:style {:background "#000 "}} (:text data)])

(defcomponent heading
  :on-render (fn [dom-node val old-val] foo)
  [data]
  [:h2 {:style {:background "#000"}} (:text data)])
EOF
[clj-kondo] Auto-loading config path: rewrite-clj/rewrite-clj
[clj-kondo] Auto-loading config path: http-kit/http-kit
[clj-kondo] Auto-loading config path: babashka/fs
[clj-kondo] Auto-loading config path: funcool/promesa
[clj-kondo] Linting file: <stdin>
defcomponent
 node: <list: (defcomponent heading :on-render (fn [dom-node val old-val] foo) [data] [:h2 {:style {:background "#000"}} (:text data)])>
<stdin>:4:42: warning: unused binding dom-node
<stdin>:4:51: warning: unused binding val
<stdin>:4:55: warning: unused binding old-val
<stdin>:6:1: error: Not a node: no docs
<stdin>:7:19: warning: unused binding dom-node
<stdin>:7:28: warning: unused binding val
<stdin>:7:32: warning: unused binding old-val
<stdin>:7:41: error: Unresolved symbol: foo
<stdin>:8:4: error: Unresolved symbol: data
linting took 61ms, errors: 3, warnings: 6

this is probably because Not a node: no docs is something you should first solve. And in the REPL you don't run with --debug

In extract-docstr you return either a vector of nodes, but the second thing is a vector of a string and a node

Yeah, should solve that. The missing print is just a (println ...)

Got it working. Please let me know if you see anything stupid being done in the hook code. https://gist.github.com/PEZ/1ac56f00b8e9e622dca2e78c66d4922a

@U9MKYDN4Q, Dumdom could provide this config automatically. Want a PR?

Very much! 🙏

https://github.com/cjohansen/dumdom/pull/52

@U04V15CAJ, the auto-config gets imported to the library project (when using Calva+clojure-lsp). Do you think I should add the auto-config to .gitignore? It risks getting a bit confusing with the duplicates…

duplicates?

I end up with the same files in resources and in .clj-kondo/cjohansen/dumdom.

you can unduplicate this by removing the files in .clj-kondo/cjohansen and then adding this to .clj-kondo/config.edn:

:config-paths ["../resources/...."]

See the explanation here: https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#exporting-and-importing-configuration

To activate the exported configuration in your local project, you can add the following to .clj-kondo/config.edn:

{:config-paths ["../resources/clj-kondo.exports/<your-org>/<your-libname>"]}

Yeah, I read that before, but thought it was if I needed the config for the library (which doesn’t seem necessary). But it makes sense that it will dedup things too. 😃

Is this on the consumer side?

this is only for linting inside your library, not for consumers

I guess my real question was: will this cause changes in the PR @U0ETXRFEWor is it ready to merge?

it will change the PR

As suspected. Thanks 😊

Not getting it to stop downloading the auto-config, though… I copied the path using VS Code to make sure I get it right. :thinking_face:

yes, it will always import the config. that doesn't make sense for this lib so in this lib you can add .clj-kondo/cjohansen/dumdom to .gitignore I guess

Fantastic documentation for the hooks, @U04V15CAJ.

Not to mention the exquisite service ❤️

Not to mention that!

A thing I missed and kept not realizing was that api/map-node does not work on maps. The docs clearly say it expects a sequable, so this is entirely on me. But wondering if it would hurt to make it work on maps too?

this stuff is directly linked to how rewrite-clj works, not sure if it makes sense to change that API