We can detect whether it is analyze-call or macroexpand based on whether it is defined as a macro or as a function, but we could also add it to the inline tag to be explicit. :clj-kondo/macroexpand-hook 'my-hook-name as one option.

I don't know if this helps since you need to define those hooks in external files anyway. I don't like to introduce any ambiguity between analyze-call or macroexpand, macros can be handled with analyze-call as well

What do you mean by external files? They’re in resources which are also part of the source code.

the idea of inline configs originated from someone who didn't like to write external files like .clj-kondo/config.edn but when you write hooks you need to add files in .clj-kondo/..../foo.clj_kondo anyway

I like to use namespaced keywords for custom hook errors: :splint/mismatched-diagnosis, etc

We have roughly 15 custom linter keywords in my job’s codebase

Nice, this worked!

> maybe it’s better to use api/reg-finding! than assert though is there a good way to obtain row and col when it is used in a macroexpand hook? I tried it outside of a syntax quote like this:

(defmacro my-hook [source & body]
  (when-not (string? source) (api/reg-finding! (merge
                                                 (select-keys (meta source) [:row :col :end-row :end-col])
                                                 {:message "source must be string"
                                                  :type :type-mismatch
                                                  :level :error})
  `(let [xyz# ~source] ~@body))

> is there a good way to obtain row and col when it is used in a macroexpand hook? the row/col metadata should be available as metadata, at least on objects that can carry metadata

if you e.g. pass a number, it's not there anymore

you could pass the metadata of the &form argument, which is the whole surrounding form

So there is no way to recover location of a number?

nope, (with-meta 1 {:row 1}) doesn't work

you might be better off with an :analyze-call hook here