Try a hook that expands to a let and then returns a vector of all of the variables

So expand to (let [z 1 a 2 b 3] [z a b <actual return value>])

Or (let [z 1 a 2 b 3] [z a b] <actual return value>)

Why not rewrite it to the actual expansion?

Or use lint-as let

i think lint-as let won't work because it'll flag as unused bindings

given:

(defmacro letm [bindings]
  (let [ks (take-nth 2 bindings)
        kws (mapv keyword ks)]
    `(let ~bindings
       (hash-map ~@(mapcat vector ks kws)))))

(letm [a 1 b 2 c (+ a b)])

(defmacro letm
  [bindings]
  (let [ks (take-nth 2 bindings)
        kws (mapv keyword ks)]
    `(let ~bindings
       (hash-map ~@(mapcat vector ks kws)))))

I’ve used a more decomplected macro in the past which just captured locals by name as a map: (->m a b c), it didn’t need any kondo config, also no unused binding

that's not exactly the same as letm. might still be useful

It’s not the same, it’s more decomplected as I said. It composes with existing let and fn bindings and lets you capture only the binding you want and not any auxiliary bindings

> Try a hook that expands to a let and then returns a vector of all of the variables > Why not rewrite it to the actual expansion? Given that let allows a number of destructuring options, figuring out every symbol I need to rewrite to doesn’t look easy. Consider these examples;

(letm [[x {:keys [y] b :b}] val])

> Or use lint-as let lint-as reports unused bindings.

Am I correct that the suggestion is to use the macroexpand hook with pretty much the original macro content?

Yes

Thanks! I’ll give it a try!

If that doesn’t work, i can try again but I’ll need to see the full macro

Do you know what kind of macros do not work with :macroexpand hooks?

I think you can pretty much make anything work but often with simplifications

This letm macro implementation is calling destructure function from clojure.core before generating the nodes and it looks like that is an unsupported external dependency.

I was afraid you might say that

I should just bump SCI which exposes destructure in the latest release

lint-as fn-traced as fn maybe?

I don't know where fn-traced is coming from, but that would probably be the solution

Aha, its re-frame-10x (the add on debugger)

So is that something I can put in the .clj-kondo file? first time using it so very green 🙂

e.g.

{:lint-as {day8.re-frame.tracing/fn-traced clojure.core/defn}}

I mean, in a config file in the .clj-kondo directory 🙂

Yep :)

I’d choose fn over defn

got it

Hmm it doesn’t seem to help, if its useful, here is the fn-traced

(defmacro fn-traced
  "Defines a traced fn"
  {:arglists '[(fn name? [params*] exprs*) (fn name? ([params*] exprs*) +)]}
  [& definition]
  `(if (is-trace-enabled?)
     (fn-traced* ~@definition)
     (fn ~@definition)))

turns out I need to name the file config.edn 🙂 sorted it!