This is because you're running clj-kondo manually, you should manually handle errors and failures

but it's now recommended to use this instead of the pod directly: https://github.com/clj-kondo/clj-kondo-bb/blob/246ac4c09ac32008025d7e8da28211e448b9fc91/src/clj_kondo/core.bb#L13

nice, like

lint
{:doc "Lint with clj-kondo."
   :task (clj-kondo/exec {:lint ["src" "test"]})}

:task (exec 'clj-kondo.core/exec)
:exec-args {:lint ["src" "test"]}

This might need better docs 😅

You can then pass additional args with --lint foo bar on the command line

but not all arguments are properly babashka.cli-ified

[sritchie@wintermute ~/code/clj/emmy (sritchie/docstrings)]$ bb lint
----- Error --------------------------------------------------------------------
Type:     java.lang.NullPointerException
Location: <expr>:20:1

----- Context ------------------------------------------------------------------
16: (when-not (resolve 'run)
17:   (intern *ns* 'run babashka.tasks/run))
18:
19: (when-not (resolve 'exec)
20:   (intern *ns* 'exec @(var babashka.tasks/exec)))
    ^---
21:
22: nil
23: (def lint (binding [
24:   babashka.tasks/*task* '{:name lint, :doc "Lint with clj-kondo.", :task (exec 'clj-kondo.core/exec), :exec-args {:lint ["src" "test"]}}]
25:   nil

----- Stack trace --------------------------------------------------------------
exec-af4cd7c4-a77a-487a-a098-1c4e132ebcc0/exec - <expr>:20:1
exec-af4cd7c4-a77a-487a-a098-1c4e132ebcc0      - <expr>:4:1
user-49a145ee-67a2-44ef-868b-b6368ff89c06      - <expr>:26:1

This is with

{:pods {clj-kondo/clj-kondo {:version "2023.01.20"}}
 :tasks
 {:requires ([pod.borkdude.clj-kondo :as clj-kondo])

  lint
  {:doc "Lint with clj-kondo."
   :task (exec 'clj-kondo.core/exec)
   :exec-args {:lint ["src" "test"]}}}}

Have you added this dependency to your bb.edn?

remove the pod stuff and add the dependency

the dependency being: https://github.com/clj-kondo/clj-kondo-bb

I'm still torn between "bb-clj-kondo" and "clj-kondo-bb"

that worked, thank you! time to upgrade all my projects…

I like the suffix version personally, mirroring the file extension

right, thanks :)

I think you inspired me to do that for mathbox.cljs etc, and then I saw you moved back to dashes!

I first actually had http://clj-kondo.bb but then all kinds of apps made that into a hyperlink to a non-existing website

haha yes that was it

how did you get GitHub to syntax-highlight bb files as Clojure? or is it doing inference on the file contents?

by making bb popular enough? 😆

I guess eventually someone made a PR to this linguist thing

https://github.com/mentat-collective/emmy/actions/runs/4388062311/jobs/7684113615

this is a bit strange, @borkdude… digging in now, but on CI, after this change,

Downloading: org/clojure/core.specs.alpha/0.2.62/core.specs.alpha-0.2.62.jar from central
----- Error --------------------------------------------------------------------
Type:     clojure.lang.ExceptionInfo
Message:  Could not resolve symbol: exec
Phase:    analysis

Error: Process completed with exit code 1.

let me upgrade babaska there and see what happens

yes, upgrade babashka :)

babashka 0.8.156 😱 that's old :)

haha hadn’t done any gardening in the actions for a while

btw I use setup-clojure for almost everything in github actions now and just say: bb: latest

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Install babashka
        uses: just-sultanov/setup-babashka@v2
        with:
          version: '1.2.174'

      - name: Cache kondo directory
        uses: actions/cache@v2
        with:
          path: ~/.clj-kondo/.cache
          key: ${{ runner.os }}-kondo
          restore-keys: ${{ runner.os }}-kondo

      - name: Run clj-kondo
        run: bb lint --config '{:output {:pattern "::{{level}} file={{filename}},line={{row}},col={{col}}::{{message}}"}}'

I bet latest would work here as well

Is this to please github with inline annotations? "::{{level}} file={{filename}},line={{row}},col={{col}}::{{message}}"}

https://github.com/babashka/sci/blob/master/.github/workflows/ci.yml#L21

woah, look at this antique

aaaargh ;)

hehe

@borkdude yeah that’s right

super cool

Hi. Can we discuss in a thread?

Can you point me to the code of your hook?

this one? https://github.com/johnmn3/dispacio/blob/master/resources/clj-kondo.exports/net.clojars.john/dispacio/dispacio/alpha/core.clj_kondo

right, and what is wrong with this one?

It might just be a clojure dependency issue

that test file in there, I believe that's what is causing a downstream consuming project to cause that read-string error above

I will check out your dependency and run it locally

and that's the only place I see it being used in the code base

$ clj-kondo --lint .clj-kondo/test.clj
linting took 31ms, errors: 0, warnings: 0

the test.clj file isn't exposed to other libraries since it's not on your exported files

Was just about to ask that 🙂

only what is inside clj-kondo.exports is going into your jar

well all of my defp statements like that, they are correctly interpreting the defmethod syntax inside it, but the outer bracket has that red underscoe

and it's complaining about the read-string unresolved symbol

can you make a repro of that in the test.clj file?

It's in clojurescript

I need a repro to look at

which might be the problem. Let me try adding up to date clojure libs

is it in the dispacio library itself?

No it's a project I'm working on locally

can you make a screenshot of the surroundings? the first screenshot was very local and not informative

(to me)

yeah, I think we could do this in clj-kondo itself: arity checking for update

feel free to log an issue

https://github.com/clj-kondo/clj-kondo/issues/2003

Already supported on master

so fast 🏃