So interestingly, if I run clj-kondo from the command line on the whole project, I don't get those errors emitted ... which suggests that maybe however clojure-lsp is running isn't finding my project's clj-kondo config? Hmmm.

This linter is implemented by clojure-lsp and doesn't work with :config-in-comment at the moment

Oh, ok. I must have been wrong that it was previously working ... thank you!

repro?

@U04V15CAJ here is an example (I might be doing something wrong)

but returning an int when the function spec says it is supposed to return string seems to cause no issues

(defn welcome-string
  {:malli/schema [:=> [:cat :int] :string]}
  [name]
  12)

(welcome-string "asd")

I think it will emit an error when you call welcome-string and use its result as a non-string. The checking between the implementation and the actual spec might currently not be implemented yet

Yup, there is an error if you try to pass the result of the function (string) to inc (which wants a number) for example

Would be huge if the return expression in the function was also typed according to its spec though!

I imagine that would prevent lots of usual errors, like accidentally returning a higher-order function instead of a number, etc

Instead of at the call site

sure, feel free to post an issue

@U04V15CAJ posted one here: https://github.com/clj-kondo/clj-kondo/issues/1973 (Sorry if I messed that up 😄)

Can you also please post some code in there to fully repro the situation? Preferably a github repo someone can clone. This will save the person who is going to implement this time.

Yeah I can, adding now

Updated issue to add repro: https://github.com/zakkor/clj-kondo-schema-return-repro/blob/master/src/clj_kondo_schema_return_repro/core.clj Hope that helps

This certainly helps, thanks!

❯ clojure-lsp clean-ns
[100%] Project analyzed
Checking namespaces...
Cleaned clojure.java.jdbc-test
Cleaned clojure.java.jdbc.spec
Cleaned clojure.java.jdbc.utilities-test
Cleaned clojure.java.jdbc
Cleaned clojure.java.jdbc.datafy
Cleared 5 namespaces

java.jdbc on  master [!?] via ☕ v17.0.1 on ☁️  metabase-query took 5s
❯ pwd
/Users/dan/projects/clojure/java.jdbc

i had a copy of java.jdbc and ran clojure-lsp clean-ns on it

that is great

@U017QJZ9M7W You're not using clojure-lsp yet?

Not yet! Stuck in my old cider and kondo setup

Sounds like I need to make an upgrade

clojure-lsp has tasks to clean-ns, format code using cljfmt and get diagnostics using kondo, all in a single tool :)