Maybe it’s good to stay away from this debate, line length tends to be a very political and emotion filled subject… 🙂

I hope I did that right: https://github.com/clj-kondo/clj-kondo/issues/1794

Yes! In the original template there is a snippet like "if you like this feature, upvote it with a thumbs up". You could leave that in

Then I can sort issues to see what people are most interested in

I think the implementation for this would be pretty easy: walk over the whole file input and emit a lint warning when a line is longer

I know nothing about the internals of clj-kondo, but it certainly sounds like a simple thing to check for.

so basically, every file being linted passes through here: https://github.com/clj-kondo/clj-kondo/blob/27a12984042afc7dc3d11327f4573a73f51176e3/src/clj_kondo/impl/analyzer.clj#L2725 the input argument is the file contents as string

When a line is longer than a certain value, you call (findings/reg-finding! ...) and that's basically it

Are you saying this because it is interesting, or because you hope I will submit a PR? (it might work)

If you're up for a PR, sure

(or for some third reason I've not considered)

I had a go at one: https://github.com/clj-kondo/clj-kondo/pull/1802 I hope I've done it right.

@peterwestmacott Awesome!

Tested it locally, works!

I think I'll leave it on for personal use ;)

Merged. Congrats and thanks.

Thanks!

@peterwestmacott Have you considered cases like this?

Nope!

What would you do in this case?

I don't know. :thinking_face:

What do other linters do here?

Again I don't know. I imagine they complain, because the line is too long.

Are you suggesting that this particular line length might be legitimate?

To my mind it is too long and shouldn't be allowed, but I can see that pragmatically that could be annoying.

It seems to point at a fundamental issue with URL length

I could imagine a 'softer' version of the linter that only looked for whitespace beyond the desired line length. That way if your line was too long, but you could argue that you 'didn't have a chance to break it' it would let you off.

> Are you suggesting... No, I honestly don't know

Afk rn or I'd check on lein bikeshed to see how it behaves, but I'd put money on it complaining.

@U051BLM8F: What does rubocop do in cases of long urls that can't be broken?

One could say "use a URL shortener" or "link to your issuer tracker and put the super long URL in there"

or long strings for that matter

I know some linters make an exception for lines with no space in them, such as a url