Working on the PR at the moment. It looks like there's no tests specifically for checking valid inferred git urls.

there is a deps.edn linter test section somewhere I think

Yeah, I'm looking at it, but it doesn't explicitly test inferred git urls.

It does test them implicitly as an aside bit during some tests it seems.

But there's no explicit tests for inferred git urls.

Feel free to add a few

Most tests are setup as: throw some code at the linter and test the output

Yeah, that's what I'm looking at. Sounds good.

Also looking at the code for it I get why you did it just as simple prefixes, so you wouldn't need a lot of these updates when new ones are added, but I do note the lint is pretty forgiving about incorrect inferred urls.

Maybe that's fine though since it'd be caught by actually trying to build the project.

There's only 24 hours in a day and so many features to work on :)

Glad you're helping out with this PR though

Yeah, that's totally fair. And I think this is a fine place to make that compromise.

Does testing work to do multiple tests with the assert-submaps bit or am I better off making two deftests?

Looks like it should work

@borkdude https://github.com/clj-kondo/clj-kondo/pull/1775

Looks good!

awesome, thanks. lmk if I need to make any changes.

just waiting for tests to pass, looks good

awesome, thanks!

Likewise!

I have locally :nrepl alias:

{:aliases 
 {:nrepl
  {:extra-deps 
   {nrepl/nrepl {:mvn/version "0.9.0"}
    refactor-nrepl/refactor-nrepl {:mvn/version "3.5.4"}
    cider/cider-nrepl {:mvn/version "0.28.5"}
    criterium/criterium {:mvn/version "0.4.6"}
    com.clojure-goes-fast/clj-java-decompiler {:mvn/version "0.3.1"}
    com.github.jpmonettas/flow-storm-dbg {:mvn/version "2.3.131"}
    com.github.jpmonettas/flow-storm-inst {:mvn/version "2.3.131"}}
   :main-opts  
   ["-m" "nrepl.cmdline" ;"--port" "14563" 
    "--middleware" 
    "[cider.nrepl/cider-middleware,refactor-nrepl.middleware/wrap-refactor]"]}}

:test
           {:extra-deps
            {org.clojure/clojure {:mvn/version "1.9.0"}
             org.clojure/clojurescript {:mvn/version "1.11.54"} ;; for extraction
             cognitect/test-runner
             {:git/url ""
              :sha "cb96e80f6f3d3b307c59cbeb49bb0dcb3a2a780b"}
             clj-commons/conch {:mvn/version "0.9.2"}
             jonase/eastwood {:mvn/version "1.2.2"}
             borkdude/missing.test.assertions {:mvn/version "0.0.2"}
             babashka/process {:mvn/version "0.1.0"}
             org.clojure/tools.deps.alpha {:mvn/version "0.12.1048"}}
            :extra-paths ["test" "extract"]
            :main-opts ["-m" "cognitect.test-runner"]}

user=> (require '[flow-storm.api :as fs-api])
FileNotFoundException Could not locate flow_storm/api__init.class or flow_storm/api.clj
 on classpath. Please check that namespaces with dashes use underscores in the Clojure
file name.  clojure.lang.RT.load (RT.java:463)

user=> (require '[portal.api :as p])
CompilerException java.io.FileNotFoundException: Could not locate clojure/datafy__init.
class or clojure/datafy.clj on classpath., compiling:(portal/runtime.cljc:1:1)

Good to see it's fixed!