Try the :macroexpand hook: https://github.com/clj-kondo/clj-kondo/blob/master/doc/hooks.md#macroexpand and see if that works for you

I'm working on a more gentle introduction to hooks here: https://github.com/clj-kondo/hooks-workshop-clojured-2022 This is work in progress and will be used for a workshop next week on ClojureD

TIL that the version of clojure-lsp I installed from homebrew is super old. After fixing that and following the example it seems to be working. I essentially just copied the source from plumbing.core but I gather that I don’t actually need to do that if the real macro is happy being run from SCI?

hmm maybe I spoke too soon. It’s not complaining anymore but emacs is now highlighting the entire (fn-> ….) form like it’s a symbol when my cursor is in it and it’s showing a gensymed symbol in the minibuffer. No idea where in the kondo->lsp->emacs chain that issue is coming from

@kallen Hmm, can you make a repro?

@kallen So this works for me:

(defmacro fn-> [& body]
  `(fn [x#] (-> x# ~@body)))

hooks-workshop.macros/fn-> hooks-workshop.macros/fn->

And then:

(def f (fn-> inc inc))
  (f 1 2)

So how are you calling fn->?

to be clear it does lint correctly now. if I do (fn-> str inc) it complains that it’s getting a string when it expects a number

What I’m seeing is that now clojure-lsp seems to think the entire fn-> form is a symbol so it highlights it and puts the symbol at the bottom, just like if I had put my cursor on def

Yeah, this is an artifact of :macroexpand . If you want more precise linting, use :analyze-call

which isn't that hard with a macro like this

Tomorrow I'll write part 3 of the workshop which should hopefully help ;)

But the docs about it should be good too

I think I get the picture of what is needed from the docs but you might have the workshop part written by the time I get to poking at this tomorrow.

is there a good way to distribute this sort of config? plumbing is a pretty popular library. Or is the idea that they become part of the library itself?

You can make a PR to put it in the config exports in the library's resources.

I think there's a community project to distribute them too if the library owner refuses to accept a PR to make it part of their library exports.

Yes: https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#exporting-and-importing-configuration Here are some examples :) https://github.com/clj-kondo/clj-kondo/discussions/1528

I think we have a fair chance of getting this into plumbing, since @U055XFK8V is a maintainer there

The community project is https://github.com/clj-kondo/config

But it's currently not fine-grained, it imports all of those which isn't really optimal

Splitting up into separate deps could work

Anyway, it's best to send the configs to the source library

cool, if I get analyze-call working and I get a free moment I’ll PR up at least the stuff that I use on a regular basis. Hopefully that will provide a kernel to grow from.

I think theoretically that should be possible since Pokemon is, at minimum, a map right?

E.g. this does warn:

(let [x {}]
  (inc x))

Yes pokemon is a map

So if you could make a repro using pure clj-kondo, and post an issue about it, we can see why it's not working and how it can be fixed