is this a false positive?

(defn sub-sequence? [seq-a seq-b]
  (->> (map #(= % %2) seq-a seq-b)
       (every? true?)))

(Im guessing its not, I can replace #(= % %2) with =, is this what this linter is looking for?)

yes

something like "^:replace {:linters {??}}"

yes, exactly that

or maybe {:linters ^:replace {}}

not sure anymore :)

"--config ^:replace {:linters {:redundant-fn-wrappers :warning}}" i guess?

is this bash?

you must then spit --config out of the string

--config "..."

zsh but yeah

i threw

(defn foo [x]
  (let [inc' #(inc %)]
    (inc' x)))

clojure -Sdeps '{:deps {clj-kondo/clj-kondo {:git/url "" :git/sha "2cc9777752d9f54ed91baa4c6ddaa0c2b8812049"}}}' -M -m clj-kondo.main --config "^:replace {:linters {:redundant-fn-wrapper :warning}}" --lint src

--config "^:replace {:linters {:redundant-fn-wrapper {:level :warning}}}"

hmm I'll try that example

Works here

hmm, with the version I previously compiled, but maybe not with the branch. taking a closer look

it also works for me when I remove that config, there must be something wrong with that part

this is with my compiled version (which is slightly behind on the branch)

This worked:

$ clojure -Sdeps '{:deps {clj-kondo/clj-kondo {:git/url "" :git/sha "2cc9777752d9f54ed91baa4c6ddaa0c2b8812049"}}}' -M -m clj-kondo.main --config "^:replace {:linters {:redundant-fn-wrapper {:level :warning}}}" --lint /tmp/dude.clj

ah, it needs a map with {:level :warning}

ah yes

success! #(vector? %) ha

oh nice, it caught a multi-arity map version

?

can you show?

(map (fn [join rhs]
       (rhso join rhs))
     joins rhses)

ah :)

the single arity versions are easy to see. i didn’t notice this one right away

nice job

you should ping ghadi about this

yeah, I've done that

he found one in nubank's code

I think I'll disable this linter by default, what do you think?

For some reason I write #(genysm) a lot

ha

makes me think of some core set of default enabled linters, and an easy way to enable all new linters that haven’t made their way into core yet?

but yeah i agree maybe not by default. but i wonder how many people use non-default linters

right, the original cause for this linter was that beginners tend to write (update foo :bar #(inc %))

and those beginners might not enable a non-default linter

Maybe I can make it opt-in for 1 quarter and then enable it by default

to get rid of initial false positives

For the curious, https://github.com/cljdoc/cljdoc/commit/abb606f8229feec8b3b83a4bc94fc119aa542aaf.