Is there a way to currently support having one splicing conditional at the end of the require block and have each part of it sorted? E.g.:

(ns some.ns
  (:require
   [com.fulcrologic.fulcro.components :as comp :refer [defsc]]
   #?@(:cljs [[com.fulcrologic.fulcro.dom :as dom]]
       :clj [[com.fulcrologic.fulcro.dom-server :as dom]])))

That currently fails the linter because (I think) after splicing it would be out of order

I'm not sure, it might just ignore these special cases to not cause false positives

It currently raises warnings for us on clj-kondo v2022.01.15 . I wanted to post the above as an arg to the clj-kondo command but I get an error saying it’s an unparsable ns form (I think because there is no file?)

you can lint from stdin using --lint -

The unparsable ns form error occurs even if there is a file. This is what I get…

clj-kondo-repro on  main [?]
❯ clj-kondo --lint src
src/myname/myapp.clj:0:0: error: Can't parse src/myname/myapp.clj, Unparsable namespace form
linting took 166ms, errors: 1, warnings: 0

you cannot use reader conditionals in .clj files

oof, sorry!

maybe clj-kondo should warn about this :)

there might already be an issue about this, but if not, feel free to make one

(about reader conditionals in .clj)

Will do, weirdly enough I could jack-in and execute forms!

the REPL might accept it

$ clj
Clojure 1.11.0-alpha3
user=> #?(:clj 1)
1

There was an issue about reader conditionals awhile back https://github.com/clj-kondo/clj-kondo/issues/80 it could be reopened?

re-opened

thanks for finding that

I’ve updated the repro project https://github.com/dcostaras/clj-kondo-repro The behaviour is now:

❯ clj-kondo --lint src
src/myname/myapp.cljc:5:16: warning: Unsorted namespace: com.fulcrologic.fulcro.dom
src/myname/myapp.cljc:6:15: warning: Unsorted namespace: com.fulcrologic.fulcro.dom-server
linting took 215ms, errors: 0, warnings: 2

@U0VP19K6K if you write:

(ns myname.myapp
  (:require
   [com.fulcrologic.fulcro.components :refer [defsc]]
   [taoensso.timbre :as timbre]
   #?(:clj [com.fulcrologic.fulcro.dom-server :as dom])
   #?(:cljs [com.fulcrologic.fulcro.dom :as dom])))

issue welcome. for now you can use a non-splice perhaps

thanks, I’ll open the issue. We’re attempting to turn it on in an existing project so probably wont change all NSs just yet! Thanks borkdude

https://github.com/clj-kondo/clj-kondo/issues/1571

Well, both. For developer feedback I used lots of (prn (api/sexpr node)) as suggested at https://github.com/clj-kondo/clj-kondo/blob/master/doc/hooks.md

This is less than ideal but it worked for now

I haven't had time to figure out a cleaner way

For testing as in QA I would just lint your sources and make sure your macros are used in such a way that should be covered by the linting

But it would be nice to be able to persist a few tests so I don't break the hook later on

and then put that linting in a test or CI job

As for dev, I'm thinking of improving that

That works to some extent but I also want to write tests that would fail the linter for specific reasons

do you mean, you do validation in the linter and would like to test for that?

yes

You can test for the linter output?

you can use clj-kondo as a JVM library and make assertions on the findings

(:findings (clj-kondo.core/run! {:lint ["input-file.clj"]}))

ooh, that would work I guess!

let me have a go at it

Is there a way to pass file contents in there as a string?

you can lint from stdin like this:

(with-in-str "(+ 1 2 3)" (run! {:lint ["-"]}))

Perfect, thank you very much

https://github.com/fulcrologic/guardrails/pull/30 in case you're interested what I needed this for. Thanks again for the help!

One more question regarding the dev workflow: using the JVM method you shared above, how can I reload the hook code I'm testing after I make changes without having to restart my repl?

test uses the project's .clj-kondo/config which references another config which sets up the hook via analyze-call

@imre Ah yeah

I think (require '[clj-kondo.impl.hooks] :reload) will work

And indeed it does! Thank you very much again!