ping @U0281QDFE1X

@brcosta Perhaps you can also rename the github repo to clojure-extras and also link to the marketplace from there.

I think the locations of the yellow stuff can be fixed by the plugin, perhaps. I did a similar thing in clj-kondo.lsp for Calva. https://github.com/clj-kondo/clj-kondo.lsp/blob/53b59828bfc6a6dab8c67ca4e1442093fec4b5c8/server/src/clj_kondo/lsp_server/impl/server.clj#L76-L88

I’ll try this approach later today 🙂

Let me take a look locally. Is this on tda master?

yep

The error goes away when I add [clojure.tools.deps.alpha] to the namespace form. I think clj-kondo expects the fdef name to be related to one of your loaded namespaces.

(ns clojure.tools.deps.alpha.specs
  (:require [clojure.spec.alpha :as s]
            [clojure.tools.deps.alpha]))

but that's not necessary

it's just a symbol going in the registry

hm yeah, it can be any fully qualified symbol. I'll fix that then

This is the config which makes those things go away for now:

{:skip-args [clojure.core/comment]
 :linters
 {:unused-binding {:level :off}
  :unresolved-symbol [(clojure.spec.alpha/fdef)]}}

you can also apply this config locally in the namespace

or before the form even:

#_:clj-kondo/ignore 

:skip-args [clojure.core/comment] can be written as :skip-comments true as well

you can also apply a separate config for comment forms:

:config-in-comment {...}

https://github.com/clj-kondo/clj-kondo/issues/1532

when I added that :unresolved-symbol line above, I suddenly got 100s of warnings/errors

seemed weird that was a vector and not a key in a map?

Ah sorry, my bad.

{:skip-comments true
 :linters
 {:unused-binding {:level :off}
  :unresolved-symbol {:exclude [(clojure.spec.alpha/fdef)]}}}

I still have to write a linter for clj-kondo's own config file :)

the (..) means, within a call to. without the parens it means: ignore this symbol itself globally. I kind of regret this but I stole this 2.5 years ago based on what joker was doing at the time. sorry about that ;)

you can also say: :exclude [(foo.bar/baz [x y z])] which ignores only the symbols x y z within calls to foo.bar/baz

which some macros which introduce arbitrary symbols can use

I checked the implementation of the fdef analysis and it was explicitly written as: if the namespace is unresolved, then the symbol is reported as unresolved. Since you can easily make typos and most people will load the namespace when they write specs.

but I guess this should be an opt-in warning and not an error

I tried that config and it didn't suppress the errors

which config did you try?

your last code block above

this one?

{:skip-comments true
 :linters
 {:unused-binding {:level :off}
  :unresolved-symbol {:exclude [(clojure.spec.alpha/fdef)]}}}

yes

it does work over here. are you sure you have that exact config with :exclude ?

I forgot to add that before

yes

% cat .clj-kondo/config.edn
{:skip-comments true
 :linters
 {:unused-binding {:level :off}
  :unresolved-symbol {:exclude [(clojure.spec.alpha/fdef)]}}}
% clj -M:lint
src/main/clojure/clojure/tools/deps/alpha/specs.clj:122:9: error: Unresolved symbol: clojure.tools.deps.alpha/resolve-deps
src/main/clojure/clojure/tools/deps/alpha/specs.clj:126:9: error: Unresolved symbol: clojure.tools.deps.alpha/make-classpath-map
src/main/clojure/clojure/tools/deps/alpha/specs.clj:130:9: error: Unresolved symbol: clojure.tools.deps.alpha/make-classpath
linting took 1088ms, errors: 3, warnings: 0

ah my bad again, I get the same. argh, yeah, it uses a "custom" way to handle that so configuring won't work.

#_:clj-kondo/ignore ;; see kondo issue #1532
(s/fdef clojure.tools.deps.alpha/resolve-deps
  :args (s/cat :deps ::deps-map :options ::resolve-args)
  :ret ::lib-map)

that will do it, or load the ns, until I fix the issue which I'm on right now.

thx

1532 is fixed on master

thx!

Fixed in newest kondo and 0.4.5 of the plugin: https://plugins.jetbrains.com/plugin/18108-clojure-extras/

@brcosta Are you sending the :filename ... so clj-kondo can see that this is .cljs code?

That is likely the issue

that would make sense, I think I also saw this on some reagent vars

reagent is cljs source, IIRC

could you make an issue at https://github.com/brcosta/clj-stuff-plugin so we don't forget?