This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2021-12-30
Channels
- # adventofcode (27)
- # ai (1)
- # announcements (2)
- # aws (66)
- # babashka (2)
- # beginners (34)
- # calva (28)
- # cider (5)
- # clj-kondo (18)
- # clojure (16)
- # clojure-europe (4)
- # clojure-norway (2)
- # clojure-uk (3)
- # clojurescript (11)
- # code-reviews (23)
- # conjure (23)
- # core-logic (1)
- # cursive (12)
- # datalevin (1)
- # datomic (9)
- # introduce-yourself (3)
- # kaocha (3)
- # klipse (4)
- # malli (42)
- # midje (1)
- # minecraft (1)
- # missionary (4)
- # music (1)
- # nextjournal (10)
- # polylith (5)
- # re-frame (2)
- # reitit (1)
- # releases (1)
- # sci (126)
- # shadow-cljs (4)
- # sql (2)
- # tools-deps (11)
👋 Hello everyone We want to use Kondo in your Github Actions, I'm taking a look at https://github.com/DeLaGuardo/clojure-lint-action However what I'm trying to figure out is, does kondo finding a problem will block my merge? I want something more flexible like being able to see the problems found as annotations, but if i want to merge, it won't stop me from doing so I know this have nothing to do directly with Kondo, but maybe someone already did something more flexibile on GH Actions
Don't know if that is configurable. I would expect so. Perhaps Github Actions supports this regardless of the action. Let's ask @delaguardo
@matthewlisp It seems you can use continue-on-error
@borkdude I tried with continue-on-error
but, some how it's failling. Or we understand in wrong way?
Well yes, but I think the way I want to work is change the way of CI work, that change the icon act like warn icon not error icon
I'm not sure how this should be done. Perhaps @U7ERLH6JX or @delaguardo know.
Based on how i remember GH API there's no warn status for jobs. Only success or failure
Maybe they change it recently but i can't check it right now
theres this status or conclusion called neutral
which probably is the closest to what you want i guess but theres no good way to set it it seems. see:
• https://github.com/actions/toolkit/issues/146
• https://github.community/t/github-actions-neutral-exit-code-is-incorrectly-interpreted-as-failure/16088
• https://github.com/actions/runner/issues/662
exit code 78 was supposed to set it and even the REST api documents it but not sure if it can be used.
maybe it could be done via an api call to https://docs.github.com/en/rest/reference/checks#update-a-check-run but it would be quite cumbersome, @delaguardo would probably know better 😄
An alternative would be to set all linter levels to :info
in your clj-kondo config ;)
There is also a --fail-level
setting for clj-kondo, but I don't know if that works with @delaguardo’s plugin
Looks like we can set it via the js sdk: https://github.com/wearerequired/lint-action/blob/master/src/index.js#L128 probably we need it as a feature in the clojure-lint-action. cc @delaguardo