Fork me on GitHub
#clj-kondo
<
2021-12-30
>
MatthewLisp15:12:38

👋 Hello everyone We want to use Kondo in your Github Actions, I'm taking a look at https://github.com/DeLaGuardo/clojure-lint-action However what I'm trying to figure out is, does kondo finding a problem will block my merge? I want something more flexible like being able to see the problems found as annotations, but if i want to merge, it won't stop me from doing so I know this have nothing to do directly with Kondo, but maybe someone already did something more flexibile on GH Actions

borkdude15:12:36

Don't know if that is configurable. I would expect so. Perhaps Github Actions supports this regardless of the action. Let's ask @delaguardo

thanks3 1
borkdude15:12:08

@matthewlisp It seems you can use continue-on-error

MatthewLisp15:12:07

Thank you very much @borkdude I think this will do 😄

👍 1
fabrao15:12:25

@borkdude I tried with continue-on-error but, some how it's failling. Or we understand in wrong way?

borkdude15:12:26

Some checks were not successful, but you can still merge, isn't this what you want?

fabrao15:12:25

Well yes, but I think the way I want to work is change the way of CI work, that change the icon act like warn icon not error icon

borkdude15:12:43

I'm not sure how this should be done. Perhaps @U7ERLH6JX or @delaguardo know.

borkdude15:12:51

Let's continue in this thread.

delaguardo15:12:21

Based on how i remember GH API there's no warn status for jobs. Only success or failure

☝️ 1
delaguardo16:12:14

Maybe they change it recently but i can't check it right now

lispyclouds16:12:48

theres this status or conclusion called neutral which probably is the closest to what you want i guess but theres no good way to set it it seems. see: • https://github.com/actions/toolkit/issues/146https://github.community/t/github-actions-neutral-exit-code-is-incorrectly-interpreted-as-failure/16088https://github.com/actions/runner/issues/662 exit code 78 was supposed to set it and even the REST api documents it but not sure if it can be used.

lispyclouds16:12:28

maybe it could be done via an api call to https://docs.github.com/en/rest/reference/checks#update-a-check-run but it would be quite cumbersome, @delaguardo would probably know better 😄

borkdude16:12:00

An alternative would be to set all linter levels to :info in your clj-kondo config ;)

borkdude16:12:11

or :warning

borkdude16:12:33

There is also a --fail-level setting for clj-kondo, but I don't know if that works with @delaguardo’s plugin

lispyclouds16:12:33

Looks like we can set it via the js sdk: https://github.com/wearerequired/lint-action/blob/master/src/index.js#L128 probably we need it as a feature in the clojure-lint-action. cc @delaguardo