🎉 how are you calling reg-finding? can you verify if the end-col and end-row are there to begin with?

about the popover - I'm not sure what clj-kondo.lsp and clojure-lsp are doing differently - is this something you would know about @UKFSJSM38?

not really, I can't see anything clojure-lsp is doing diferently about that :thinking_face:

perhaps it has to do with end-row / end-col then

hum, makes sense as the warning needs a end-col and end-row on client side

> perhaps it has to do with end-row / end-col then what interesting is that the message is not showing up for default linters as well

this one seem to include end row/col

maybe clj-kondo.lsp needs to upgrade the lsp library? it's pretty old probably

but this intellij lsp plugin is also pretty old

yeah, my guess is the intellij plugin

but he uses the same lsp intellij plugin for clojure-lsp?

oh and does it work for clojure-lsp?

wait...

nah it doesn't, I've double checked

no message in a popover in both kondo lsp and clojure-lsp

yeah, so it sounds like a intellij plugin issues indeed

god dammit

Come to emacs 😛 Just kidding, unfortunately the intellij lsp plugin is not actively mainted as much as other lsp editors plugins :/

https://github.com/gtache/intellij-lsp

last commit was from apr/2020

hehe, I guess I'll stop writing those linters then

@U0FR82FU1 you're still writing it for those who use clj-kondo on the command line or in other editors ;)

Although, clj-kondo is used a lot, for example on clojure-lsp that is used on editors like VScode/emacs/vim

Clojure community really needs more hands to provide a good dev experience

IntelliJ just needs better LSP support

lots of Pitchers are using Cursive, but yeah, could be useful for others and CI as well

yeah, besides that, IMO the tools overall are really good for clojure

I've also asked @U0567Q30W if he was interested in adding clj-kondo to Cursive, and he was open to that. You can bring this to his attention again.

it'd be really good @borkdude for a common lib and configuration 🙏

And ask in #cursive how other Cursive users are using clj-kondo, there are a few of them

at least at nubank, the people who use cursive doesn't just run the lint on the command line and fix it manually :(

and for complex macros (that we have clj-kondo config) they just live with that not working on cursive 🥲

that's why Nubank is now recommending to new devs using editors with LSP support :)

gluing everything together is hard

perhaps forking the lsp plugin could work - but I can imagine that appears to be a daunting task

or making a bespoke intellij plugin for clj-kondo - but I really hope that @U0567Q30W will just add clj-kondo support to Cursive

There is an open source IntelliJ plugin called Clojure-Kit

which could maybe be forked and hacked upon to get diagnostics

@U0FR82FU1 another thing btw. does CIDER work with intellij - i.e. do CIDER warnings get propagated to intellij as diagnostics?

then clj-kondo could maybe work as a cider plugin-ish or so

There must be a light weight way to get clj-kondo working in that environment

No idea :woman-shrugging:

you don't use CIDER with intellij?

the problem is, I could make an intellij plugin, but I never use it, so it wouldn't be as maintained as when I would use it

no, I only use what Cursive provides out of the box, now trying with clj-kondo, but no luck so far

@U0FR82FU1 btw, you can also get clj-kondo running as a github action and it will print diagnostics in the code as feedback

so when you push to a branch, this will still help you get feedback

we do use it to lint PRs, working great 👌

I think @U5B8QSSC9 configured clojure-lsp on intellij, maybe ask if he got the same issue with the popup

He works on Pitch as well :p

@U0522TWDA I think also uses clj-kondo + Cursive...

trying with file watcher, seems like it works for others

@UKFSJSM38 Otto is running it via lsp jar as well 🙂

I had some problem with using clj-kondo directly via a file watcher, which I don't remember. And I have given up on Clojure-lsp because the IntelliJ LSP plugin somehow sends many unfounded "file changed" messages in a short time (on my largish project) , which kills my cpu. So I started using kondo via a pre-commit hook.

@U0522TWDA clojure-lsp is ATM ignoring those messages so maybe give it another try makes sense?

Ah, awesome, thanks! Will try!

doesn't work via file watchers at all, lol

prints something about FILE_PATH is undefined, but ignoring that var doesn't make any difference

although I do see linting output in IDE's console

@U0FR82FU1 here are some instructions: https://github.com/clj-kondo/clj-kondo/blob/master/doc/editor-integration.md#file-watchers--installed-binary

that's what I've followed

@U06S1EJPL has edited that section a few times - perhaps he knows stuff?

@U0FR82FU1 I've talked to @UQTHDKJ8J who is the author of a IntelliJ plugin called "Clj Stuff" and it will soon support clj-kondo

That's really good news!

@U0FR82FU1 https://clojurians.slack.com/archives/CHY97NXE2/p1640817053272400