I tried something like this:

"clj-kondo-deps"  ["run" "-m" "clj-kondo.main" "--copy-configs" "--dependencies" "--config" ".clj-kondo/config.edn" "--lint" ~#(clojure.string/join ":" (leiningen.core.classpath/get-classpath %))]
            "clj-kondo"       ["do" ["clj-kondo-deps"] ["run" "-m" "clj-kondo.main" "--config" ".clj-kondo/config.edn" "--lint" "src" "test"]]

this is documented in the README of clj-kondo

then lein clj-kondo would first lint the classpath and then the project

you have to use --lint $(lein classpath)

the docs only say running from cli, not from lein aliases

right, I'm not sure, haven't used it that way yet

I think that would have to run as a lein plugin then

yeah, $(lein classpath) inside lein project.clj would fall into a infinte loop hehe

yeah that's what I thought, is there any clj-kondo lein plugin?

don't think so

haven't you made such a plugin for clojure-lsp?

I tried ~#(clojure.string/join ":" (leiningen.core.classpath/get-classpath %)) that lein would eval that, but it returns a function not a string

yes

try #=(....)

oh, didn't know about that one, let me try

doesn't seems to work 😕

but why not implement a proper plugin? why do you need this?

a plugin would solve the issue

because at nubank we have this lein clj-kondo alias for all services, but it's missing lint the classpath before to copy the configs and dependencies to cache

cool. we could host the plugin under the clj-kondo organization

and I'll give you the access so you can push there if you want

LGTM 🙂

what should the name of the repo be, lein-plugin?

I'd suggest lein-clj-kondo

ok

you're the admin of https://github.com/clj-kondo/lein-clj-kondo

thanks, I'll work to have something similar to clojure-lsp lein plugin

Do you think the plugin should call clj-kondo.core/run! or clj-kondo.main/main ? if the former, the api for the plugin would look something like:

lein clj-kondo "{:lint "src" ...}"

lein clj-kondo --lint src 

actually, I'm not sure how we would solve the classpath issue in the plugin

oh, actually it's easy, it's just call lein classpath ns

we just need probably to parse a specific flag to know we should get the classpath

so maybe use the clj-kondo.main/main seems the best approach

just adding a interceptor layer to check if the arg to lint is a "$classpath" or something like that

do people normally configure lein plugins in EDN?

I don't think so

Just pushed a working version to master, LMK if you think we should change anything

otherwsie we can release a initial version with make tag 0.1.0

(we can change the release process as you want as well)

also, the artifact is clj-kondo/lein-clj-kondo , not sure if that group-id is correct though

I would prefer it if you used babashka tasks instead of Make ;)

haha I thought you would say that

yeah, I can change it 🙂

how do you think the release task would look?

I'll get back to you after dinner

Done! looks better indeed, rocks

LMK what you think

That's better :) Probably a typo here: https://github.com/clj-kondo/lein-clj-kondo/blob/48c30a2059b0127862cc36b42c1f9d4516630ae0/scripts/lein_clj_kondo/ci.clj#L24

yep, fixing ...

done!

here is an example repo of clj-commons: https://github.com/clj-commons/infra it uses a bb script as well to push a tag

but I think you already have everything you need

so what's next?

oh good to know

if everything looks fine we can bb tag 0.1.0

and then bb deploy

the last one would need clojars credentials, so I think you need to do this

BTW, can you confirm if you have a verified group of clj-kondo on clojars?

since clj-kondo is a little bit old project, the group restriction was not need in the time for clojars

I have the group, but even if you have the group, you can't push any new projects to it

only existing ones

oh yeah

so I'll make a new one ok

I just saw it:

with the com.github

yeah, we need to update project.clj so

and pom.xml

oh crap, this is linked to github accounts right

so we have to go through some process?

yeah hahah you will need to open an PR

https://github.com/clojars/administration/issues/105

we need to open that issue but first create the repo or the name of who is opening the issue

@UKFSJSM38 opened it here: https://github.com/clojars/administration/issues/131

let's wait for them to respond

Perfect, thank you!

So what is interesting about the clj-commons infra setup is that you can push a tag

and then the CI will deploy

so we need only one deploy token for whoever can push the tag

which lives in CI

perhaps we can set that up?

yeah, I have that for clojure-lsp

cool

do you have a example of a project using the clj-commons infra ?

yeah lemme check

this doesn't use infra but it responds to the tag change: https://github.com/clj-commons/clj-yaml

yeah, that could work

but what function from infra we want to use to deploy to clojars?

we can just run lein deploy clojars

oh, ok, and setup the clojars credentials using github secrets, right?

(that's how I do for clojure-lsp)

yes, or circleci secrets

if your clojure-lsp setup works you can just re-use that as well

👍 alright, I'll work to do the deploy on CI instead of manually

yay

Just pushed, it uses this action I use on clojure-lsp as well to deploy t oclojars: https://github.com/marketplace/actions/publish-to-clojars so it's a really simple action

we just need to setup those 2 secrets on the clj-kondo org or on lein-clj-kondo repositoy

CLOJARS_USERNAME
CLOJARS_PASSWORD

ok, I will do that, once I get the group

chicken and egg, I can't make a token without the group

hahaha true

I can't access the public created repository: https://github.com/clj-kondo/clojars-verification-borkdude :thinking_face:

Is that really public?

a sorry, made it public

The group was verified, LMK when the secrets on Github were configured properly so I (or you) can release the tag

yes, I'm seeing it.

I'm looking into how I can make a deploy token for this new group

I don't see the group in the list for making a deploy token, I'll ask toby