Fork me on GitHub
#clj-kondo
<
2021-08-08
>
Drew Verlee13:08:27

My goal is to see if i can help with some of the clj-kondo open issues. I believe my best bet is first to establish how to run the main functionality so i can what information is returned and how it's used. My intution is that that functionality is contained in clj-kondo.core/run!. Luckily there is even an example in a comment. Is this example still good? I see a files key that doesn't seem to be used by the function https://github.com/clj-kondo/clj-kondo/blob/974540e83401c9c5def1d92cb1d8fc3ae945f736/src/clj_kondo/core.clj#L210

borkdude13:08:45

@drewverlee I think that comment form is stale :). I think your best bet for working examples is the test suite

borkdude13:08:06

Thanks for the intent to help out!

borkdude13:08:11

I have marked a bunch of tickets as "PR Welcome": https://github.com/clj-kondo/clj-kondo/issues?q=is%3Aissue+is%3Aopen+label%3A%22PR+welcome%22 That doesn't mean that other issues aren't welcome to PR-ed but sometimes a ticket needs more thought/discussion before implementation. The PR welcome tickets are fairly well figured out already.

Drew Verlee13:08:42

thanks @borkdude ill take a look.

❤️ 3
Drew Verlee22:08:00

One of the things that i'm constantly perplexed by is how often my repl experience breaks or changes from project to project. In this case if i try to eval this file, i'm told that linters/arity-error doesn't exist. https://github.com/clj-kondo/clj-kondo/blob/974540e83401c9c5def1d92cb1d8fc3ae945f736/src/clj_kondo/impl/analyzer.clj#L954

Drew Verlee23:08:28

@borkdude It's hard to tell by looking at the tests where to trace back the code that's being tested. e.g https://github.com/clj-kondo/clj-kondo/blob/master/test/clj_kondo/analysis_test.clj#L22 doesn't explicitly call upon any function (i can tell). Would i be correct in assuming an issue like https://github.com/clj-kondo/clj-kondo/issues/426 might be solved by assing an linter and i should read https://github.com/clj-kondo/clj-kondo/blob/master/doc/linters.md#L1