trying to use :analyze-call hooks to implement some custom linting, but am unable to exclude callsites using the #_{:clj-kondo/ignore [:some-linter]} form

e.g. I'm trying to error on calls to satisfies? with this code:

(defn satisfies-hook
  [{:keys [node] :as input}]
  (let [m (meta node)]
    (api/reg-finding! {:message "use of satisfies? is not allowed!"
                       :type :rpl-satisfies?
                       :row (:row m)
                       :col (:col m)
                       })
    node))

but this code still causes linting to fail:

(defn platform-executable?
  [o]
  #_{:clj-kondo/ignore [:rpl-satisfies?]}
  (satisfies? PlatformExecutable o))

any suggestions on how to do this?

@nathanmarz You need to add :rpl-satisfies? into your linter config as well, {:linters {:rpl-satisfies? {:level :error}}}, have you done this?

ah I see!

you also need to include :end-row and :end-col, else the ignore annotation doesn't know what the span is where the ignore is valid

@nathanmarz let me know if that fixes it for you

you could perhaps just assoc onto the metadata and pass that to reg-finding!

oh, about the return value: you don't have to return anything, if you're not transforming. just return nil will do

@borkdude that fixed it

really cool tool, excited to make use of it

that's always nice to hear :)

are there any known issues with running kondo via lein?

running via CLI works great, but the lein runner is unreliable for me

it sometimes has errors like <path>:11:1: error: Attempting to call unbound fn: #'hooks.core/custom-hook

these are the commands I'm using:

lein with-profile kondo clj-kondo --lint 'distributed/src/clj:core/src/clj:distributed/test/clj:core/test/clj' --parallel --config-dir .clj-kondo-jenkins --fail-level error

clj-kondo --lint 'distributed/src/clj:core/src/clj:distributed/test/clj:core/test/clj' --parallel --config-dir .clj-kondo-jenkins --fail-level error

and what is in your lein profile?

oh I see

profile is :kondo {:dependencies [[clj-kondo "2021.07.28"]]}

is the hooks.core code inside your .clj-kondo-jenkins folder in hook/core.clj ?

and alias "clj-kondo" ["run" "-m" "clj-kondo.main"]

the hook are in .clj-kondo-jenkins/hooks/core.clj

and you are sure there is a var there named custom-hook?

yes

(should be, because with the native CLI it works)

also, the errors with lein are random

sometimes it has those errors, sometimes it doesn't

sometimes it says this: WARNING: error while trying to read hook for...

can you try without --parallel?

to investigate if this is some kind of concurrency bug

> WARNING: error while trying to read hook for... can you post the entire message?

it appears to be reliable without --parallel , no errors 6x in a row

already cleared the CLI, let me try to recreate that error

hmm, interesting.

yeah, I think I know what's going on, the require inside of the interpreter isn't thread safe :)

could you please post an issue about this?

preferably with a repro, but I think I can reproduce it myself

WARNING: error while trying to read hook for rpl.helpers/returning: Could not resolve symbol: hooks.core/returning-fn

satisfies? is a relatively common function, if you lint multiple dirs at the same time, the concurrent require might cause trouble somewhere

I should use a locking or so around the loading of the hook code

@nathanmarz you know what, let me push a quick fix and you can use that deployed artifact in your CI

just a minute

thanks

@nathanmarz try [clj-kondo "2021.07.29-20210729.150232-2"]

also made an issue for SCI (https://github.com/borkdude/sci/issues/592)

@borkdude lein with --parallel looks to be reliable now

awesome

I'll add some tests later

curious that this didn't manifest in the binary.

Hi all, I have the following specter path

(def POST-ORDER-VALS
  (sp/recursive-path []
                     p
                     (sp/cond-path map?
                                   (sp/continue-then-stay [sp/MAP-VALS p])
                                   sequential?
                                   (sp/continue-then-stay [sp/ALL p])
                                   set?
                                   (sp/continue-then-stay [sp/ALL p])
                                   sp/STAY)))

{:linters
 {:unresolved-symbol
  {:exclude [thrown-with-data? recursive-path]}}}

@richiardiandrea you can do {:exclude [(com.rpl.specter/recursive-path)]} to ignore unresolved symbols inside of a call to that function

and (com.rpl.specter/recursive-path [p]) to ignore only p

it's a co-incidence that @nathanmarz was just here and just after that someone asks a question about specter :)

perhaps specter can provide better support by providing some hooks or macroexpansions as part of the library (if that makes sense for the above case, not sure)

yeah lol I have just seen it up there 😉

Thanks both to you and Nathan for these great tools