so i'm trying to build master as well as the ignore-form branch, but it seems i'm doing something wrong. i'm using the jdk 11 20.1.0 version of graal on linux -- bash script/compile gives me this: https://pastebin.com/uJZNZKFF i noticed that the build.md doc now mentions something about using jdk12 to update resources: https://github.com/borkdude/clj-kondo/blob/master/doc/build.md#optional-steps is that something i need to do to build from source now?

It's been upgraded to 20.2.0 now

so are you saying i must use 20.2.0? i'm fine to do so.

The optional steps are optional, so don't bother with those

yes

ok, thanks!

We should mention 20.2 in that README

it also has to be java11 now

PR welcome!

We can only run with one specific GraalVM version due to the reflector fix

ok -- gotta go out for a bit, but when i get back i'll try the steps and update the docs if i'm successful 🙂

ok, 20.2.0 seemed to be enough -- PR with doc update suggestion sent

@borkdude so i tried the ignore-form branch. the basic functionality seems to work :thumbsup: i don't know if i did something wrong, but the following seemed to also affect linting:

(let [x 1]
  {:clj-kondo/ignore [:redundant-let]}
  (let [y 2]
    (inc x y)
    ))

$ ./clj-kondo --lint ignore-form.clj
ignore-form.clj:4:5: error: clojure.core/inc is called with 2 args but expects 1
linting took 17ms, errors: 1, warnings: 0

when i comment out the map, the linting goes back to normal

(let [x 1]
  ;;{:clj-kondo/ignore [:redundant-let]}
  (let [y 2]
    (inc x y)
    ))

$ ./clj-kondo --lint ignore-form.clj
ignore-form.clj:3:3: warning: Redundant let expression.
ignore-form.clj:4:5: error: clojure.core/inc is called with 2 args but expects 1
linting took 7ms, errors: 1, warnings: 1

Oh, that's weird!

I'll log this as an issue to fix

ah so does it happen for you?

yes

ok thanks

oh hmm, no this is intended, since the map makes the let not be redundant anymore ;)

lol

hadn't thought of that 🙂

Input welcome on having multiple config dirs for shared config/hook code: https://github.com/borkdude/clj-kondo/issues/992

^ What if the Rum library hook config was part of the Rum library itself and clj-kondo could read it from your classpath?