Fork me on GitHub
#clj-kondo
<
2020-08-19
>
martinklepsch12:08:58

@borkdude I tried the updated hooks now and it’s a huuuuuge improvement πŸ‘ Only last issue I’m having is that the docstring seems to be expected in the wrong place, according to the docs it should appear after the component name: https://p22.tr4.n0.cdn.getcloudapp.com/items/yAubDXb2/Image%202020-08-19%20at%202.50.45%20PM.png?v=ec0644f5c4dcb74d72953b01901f963c

fiddlerwoaroof17:08:24

Is this lint message wrong?

fiddlerwoaroof17:08:35

It looks like clj-kondo doesn't recognize custom transducers

borkdude17:08:36

You can override the type config, if it's bothering you enough right now

fiddlerwoaroof17:08:50

It's fine for now, this is in my "sandbox" project

borkdude17:08:26

@martinklepsch What's a docstring?

πŸ˜† 2
borkdude17:08:47

@martinklepsch Kidding. That's probably not too hard to fix. If you want, you can make an issue, or if you feel inclined, a PR

lread19:08:39

I thought you were glitching there for a second! simple_smile

borkdude19:08:27

It was clickbait to seduce you to do a PR

lread19:08:34

Nice marketing!

borkdude10:08:03

@martinklepsch Fixed it on master

lread12:08:46

Yay @martinklepsch! And thanks for letting me know, I have crossed it off my todo list!

martinklepsch12:08:28

Thank youuuu! πŸ™Œ I tried digging into the hooks DSL a little bit a few weeks ago and had a hard time getting started 😬 πŸ˜…

borkdude12:08:08

Hopefully more examples makes it easier. It surely helps if you have used rewrite-clj before