This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (2)
- # architecture (33)
- # babashka (4)
- # beginners (445)
- # bristol-clojurians (10)
- # calva (23)
- # cider (43)
- # clj-kondo (36)
- # cljs-dev (13)
- # cljsrn (20)
- # clojure (136)
- # clojure-argentina (8)
- # clojure-dev (1)
- # clojure-europe (18)
- # clojure-germany (1)
- # clojure-italy (5)
- # clojure-nl (45)
- # clojure-spec (66)
- # clojure-uk (29)
- # clojurescript (69)
- # conjure (157)
- # cursive (2)
- # datomic (216)
- # emacs (10)
- # exercism (4)
- # figwheel-main (8)
- # fulcro (30)
- # graphql (21)
- # hoplon (5)
- # kaocha (7)
- # leiningen (3)
- # luminus (4)
- # music (1)
- # off-topic (24)
- # pathom (10)
- # re-frame (19)
- # reagent (11)
- # reitit (16)
- # remote-jobs (1)
- # ring-swagger (5)
- # rum (7)
- # shadow-cljs (125)
- # spacemacs (8)
- # sql (9)
- # tools-deps (12)
Does anyone know if there’s a way to make warnings non-fatal in the
DeLaGuardo/[email protected] GH action?
can you share your action output? currently action should exit with 0 exit code in case “warnings only | no errors”
Yes, it’s doing that. The task itself exists with 0 (i.e. passes) but the “clj-kondo check” has warnings and is marked as failing:
I used “neutral” check status to indicate that there are some warning. What do you think?
Yes, I think that would make sense to me, perhaps it could also be configurable?
I guess it would be nice to be able to see when you previously had no warnings but a given change introduces some
Cool makes sense. I guess once we’ve fixed all warnings we might want the status to be “Failed” when new warnings are introduced. But “Neutral” is also ok for now.
I would like to keep the config as small as possible. don’t think the option like what to do in case of neutral status make a lot of sense.
also it is not possible in general to get status of previous check-run because GH can mark it as stale
Yeah I mean more like being able to tell the action to use “Failed” or “Neutral” state when there are warnings
Have you considered filtering warnings so that they are only added to changed lines?
@ What if you change the arity of a function and don't change callsites accordingly? Then you won't be warned about that?
@ good point! but I guess that would be an error and errors should always be shown
@ Some people use ReviewDog to accomplish only being warned about new warnings and errors
JUXT are doing this. Here is their config: https://github.com/borkdude/clj-kondo/issues/844#issuecomment-609827001
Hi, I was looking if there's any way to make kondo ignore a specific namespace "required but never used". Also, I think I found a bug - clj-kondo warns that this required is never used, but down below the code it is being used: https://github.com/mauricioszabo/atom-chlorine/blob/master/src/chlorine/repl.cljs#L8
@mauricio.szabo I think this is caused by:
[chlorine.ui.atom :as atom] [repl-tooling.editor-integration.evaluation :as e-eval] ["atom" :refer [CompositeDisposable]]
"atom" require, or because
atom (the alias) becomes ambiguous with the function?
the alias is ambigious because there is a namespace called
atom but also a namespace alias
I don't understand, to be honest.
The namespace, you mean, is the
@mauricio.szabo I think we can reproduce the bug simply in terms of normal Clojure:
This says that namespace a is unused, while in reality, it's b that's unused. So aliases have preference over full namespace names
(ns a) (def x :a) (ns b) (def x :b) (ns c (:require [a :as b] b)) b/x