This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2020-03-23
Channels
- # babashka (68)
- # beginners (133)
- # calva (5)
- # chlorine-clover (21)
- # cider (40)
- # clj-kondo (42)
- # cljs-dev (31)
- # clojure (53)
- # clojure-austin (1)
- # clojure-europe (30)
- # clojure-italy (6)
- # clojure-nl (3)
- # clojure-uk (104)
- # clojurescript (15)
- # datascript (2)
- # datomic (50)
- # emacs (12)
- # fulcro (82)
- # graalvm (4)
- # hoplon (225)
- # jobs (4)
- # jobs-discuss (7)
- # joker (5)
- # juxt (17)
- # kaocha (13)
- # leiningen (16)
- # meander (21)
- # nrepl (18)
- # off-topic (16)
- # pathom (8)
- # pedestal (13)
- # perun (1)
- # re-frame (4)
- # spacemacs (23)
- # testing (28)
- # unrepl (3)
- # vim (5)
- # xtdb (1)
does the master branch currently pass all tests? it is failing on 2 tests and throwing 1 error on my machine
@mitchell_clojure Yes. What tests are failing for you?
Try script/test
. This will populate your .m2 cache with certain dependencies that are linted in the tests.
# populate mvn cache for extract tests
clojure -Sdeps '{:deps {org.clojure/clojure {:mvn/version "1.9.0"}}}' -Spath > /dev/null
clojure -Sdeps '{:deps {org.clojure/clojure {:mvn/version "1.10.1"}}}' -Spath > /dev/null
clojure -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.520"}}}' -Spath > /dev/null
ERROR in (run!-test) (core.clj:4789)
file arguments jar file as string or file
expected: (= findings (:findings (clj-kondo/run! {:lint [(io/file (System/getProperty "user.home") ".m2" "repository" "org" "clojure" "spec.alpha" "0.2.187" "spec.a
lpha-0.2.187.jar")]})))
actual: java.lang.ClassCastException: class .File cannot be cast to class java.lang.CharSequence (.File and java.lang.CharSequence are in module jav
a.base of loader 'bootstrap')
at clojure.core$re_matcher.invokeStatic (core.clj:4789)
clojure.core$re_find.invokeStatic (core.clj:4838)
clojure.core$re_find.invoke (core.clj:4838)
clj_kondo.impl.core$filter_findings$iter__8301__8305$fn__8306$fn__8307$fn__8310.invoke (core.clj:291)
.
.
.
FAIL in (extract-clojure-core-vars-test) (extract_var_info_test.clj:12)
expected: (contains? vars (quote future))
actual: (not (contains? #{} future))
FAIL in (extract-clojure-core-vars-test) (extract_var_info_test.clj:13)
expected: (contains? vars (quote transduce))
actual: (not (contains? #{} transduce))
let me double check my environment
running on linux, openjdk 11
with lein clean
then ./script/test
just to make sure, you are on master? and your HEAD = 45c615fc969ab616303283faf3d3c744b6e71ba2
?
yeah, on the bump version commit
yeah sure, I'll have to work on it some more tonight, but I'll update you on if it is an issue that could be accounted for on the public docs or not
to add some context, though, I think it may be something up with my dev environment because Cider has had trouble with namespace resolution for some classes like namespaced-map-node
yeah I still get the errors on a completely clean copy of the repo
have to do work now but I will follow up on this
Hi,
We’re using plenty of goog.global
in our codebase and I’m trying to get it ignored by clj-kondo
. I thought I’d use :unresolved-symbol for that but I’m getting a java.lang.IllegalArgumentException: no conversion to symbol
.
Here’s an example with version v2020.02.28
clj-kondo --config '{:linters {:unresolved-symbol {:exclude [(goog.global)]}}}' --lint - <<< "(def global goog.global)"
Anything obvious I’m doing wrong here? Also is :unresolved-symbol
the way to go for goog.global
or is there a way that I could use to actually get it working?
Thanks 🙇
@ullrich.schaefer if goog.global is not a function, don't wrap it in parens:
$ clj-kondo --config '{:linters {:unresolved-symbol {:exclude [goog.global]}}}' --lint - <<< "(def global goog.global)"
linting took 7ms, errors: 0, warnings: 0
is goog.global
something that is always defined in CLJS? then I think clj-kondo should just ignore it for CLJS
I believe goog.global
is always defined. But I might be missing something obvious (again 😉).