Fork me on GitHub
#clj-kondo
<
2020-03-22
>
didibus04:03:29

Time flies, but clj-kondo and sci I think are the best thing to happen to Clojure's ecosystem after cider(and orchard)

didibus04:03:37

So Happy Birthday to it!

serioga16:03:29

damn, CLJS analyser does not like multiple requires

Only one :require form is allowed per namespace definition at line 1 src\app\lib\react\mixin\data_table.cljc

serioga17:03:22

and this case is not warned as incorrectly ordered

(:require
    [app.lib.html.icon :as icon]
    [app.lib.react.component :as component]
    [app.lib.react.mixin.push-state :as push-state]
    [app.lib.react.mixin.static-args :as static-args]
    [app.lib.react.util :as react-util]
    [cuerdas.core :as cuerdas]
    [rum.core :as rum]
    #?(:cljs [app.lib.util.history :as history])
    #?(:cljs [xlsx]))

borkdude17:03:00

expected: requires in reader conditionals do not have a defined sort order, so they are ignored

serioga17:03:16

are not reader conditionals “expanded” to code?

borkdude17:03:20

@serioga they are, but if you do clojure-sort-ns in emacs, all reader conditionals go on top for example. because editors have different ways of dealing with reader conditionals, I have disabled that linter for reader conditionals, because it's a source of conflict between the linter and editor tooling

serioga17:03:06

hm, but in this case reader conditionals work for order analyser...

(:require
    [app.lib.react.component :as react-component]
    #[email protected](:clj  [[app.lib.react.mixin.push-state :as push-state]
               [cemerick.url :as url]
               [cuerdas.core :as cuerdas]
               [ring.util.request :as ring-request]]
        :cljs [[rum.core :as rum]])
    [app.lib.util.transit :as transit])