@borkdude The :missing-docstring linter warns on deftype declarations like (deftype Foo [x]) . Is it intended behavior?

That's probably a false positive. Issue welcome.

Same for deftest I see.

(ns foo
  {:clj-kondo/config {:linters {:missing-docstring {:level :warning}}}}
  (:require [clojure.test :as t]))

(deftype Foo [x])

(t/deftest foo)

yes, deftest too single issue for both?

yeah

just paste that code into the issue

in carve we ignore vars that are created by deftype / deftest, etc like this: https://github.com/borkdude/carve/blob/0e2a6014e684b2f2cea9e95e44d7bab215ba904f/src/carve/impl.clj#L108-L118

probably the same applies to this linter

800! https://github.com/borkdude/clj-kondo/issues/800

thank you

but it's possible to add docstring in both cases!

it is?

(deftest ^{:doc "Docstring"} my-test)

hmm

but for defrecord it useless.

it's not very common I think to write docstrings for tests

people usually use testing

but anyway deftest has no syntax for docstring

yeah, I think we just are going to ignore deftest and deftype for missing docstrings

«it's not very common I think to write docstrings for tests» I guess very uncommon

@borkdude hm, I cannot disable :unresolved-namespace linter for specific namespaces?

why would you want to do that?

I use criterium-core in comment criterium dependency is in profiles.clj I don't want import it in the file

well, the (require '[criterium.core]) before “fixes” this issue...

yeah, that's the way to do it.

Should not we lint for missing docstring for namespaces as well?

can do. I would say as an option to the existing linter.

or would you say, just enable it always for that linter?

the option is more flexible I guess.

or maybe enable it by default but people can turn it off?

{:missing-docstring {:level :warning :namespace-declaration false}?

I don't have enough experience to say what is better Probably library and application developers have different expectations for default settings

I'll think about it some more. Welcome to post an issue about this.

Maybe it would be useful to have an option like {:profile :lib}, and defaults change accordingly

@borkdude about namespace docstrings? https://clojurians.slack.com/archives/CHY97NXE2/p1584026520189500

ah, another topic was introduced later, OK

I'll create issue

https://github.com/borkdude/clj-kondo/issues/801

as another topic I mean https://clojurians.slack.com/archives/CHY97NXE2/p1584026536189900

if people need different settings for a lib, they can just change their config accordingly

there isn't going to be one default that satisfies everyone

people don't care but idea is to provide a guide for best practices for corresponding context

at least on documentation level, as examples

for example "missing docstring" is disabled by default. but it is no-go for libraries 🙂

depends

to easily apply https://clojure.org/community/contrib_howto#_coding_guidelines

again about rum macros.

(defcs name doc-string? (< mixins+)? [ state-arg params* ] render-body+)

(rum/defcs hello-world
  "Example react component."
  [state name]
  "foo")

what are you linting rum as?

what is your config?

:lint-as {app.database.hugsql/declare-fn clojure.core/declare
           mount.core/defstate clojure.core/def
           mount.tools.macrovich/deftime clojure.core/do
           rum.core/defc clj-kondo.lint-as/def-catch-all
           rum.core/defcs clj-kondo.lint-as/def-catch-all
           rum.core/defcc clj-kondo.lint-as/def-catch-all}

ah, without lint-as there is no message about docstring

that seems like a false positive then. you can append it to the existing issue.

including your config

hm, without lint-as it does not detect missing docstring...

without lint-as it doesn't know what this macro is, so it also doesn't know it should have a docstring