Fork me on GitHub
#clj-kondo
<
2020-01-26
>
jvtrigueros00:01:51

I recently switched to the LSP version because I noticed a slight lag when typing. I don’t see this lag with LSP. Both work great!

Janne Sauvala08:01:23

I’m using Intellij 2019.3.2 and downloaded the LSP plugin from the IDE’s marketplace and the plugin crashed to an exception. Are you using the same setup?

jvtrigueros20:01:56

You must get the unreleased version from the same author. The one from the marketplace doesn't work with the latest version of clj-kondo

1
borkdude20:01:30

Maybe the jar I just posted does

borkdude20:01:49

Not sure, but I made some changes regarding end locations.

jvtrigueros20:01:15

I turned on logs in IntelliJ but it wasn't enough to tell me why it wasn't working.

jvtrigueros20:01:01

Ok, just tried the SNAPSHOT with LSP version 1.5.4 and it's not working, let me upgrade manually to 1.6.0

borkdude20:01:49

1.6.0 is still not available in the marketplace?

jvtrigueros20:01:00

Not yet. It's still pending.

borkdude20:01:53

If you're testing the SNAPSHOT, please pay attention to misplaced squiggles

jvtrigueros20:01:26

kk, one sec restarting IJ for the 5th time :D

jvtrigueros20:01:29

Ok confirming that LSP 1.6.0 works with the SNAPSHOT. I'll move off this thread to report issues (if any with LSP+kondo)

borkdude20:01:43

thanks! ❤️

borkdude20:01:34

Anyone using the LSP server, please test this new server before I release it into the wild:

👍 1
jvtrigueros20:01:52

The squiggles are now on the parens, is that by design?

jvtrigueros20:01:31

wait wait I haven't upgraded, false alarm sorry I did upgrade, just got confused above still holds

borkdude20:01:13

I don't know what was the behavior before, but now it's the same as emacs, which isn't bad imho:

borkdude20:01:47

Before clj-kondo only reported the start location and the editor had to make sense from that only where to put the squiggles

borkdude20:01:17

One issue I solved after introducing this was that the entire sexpr would be squiggled which is quite annoying.

jvtrigueros20:01:10

Let me revert and compare

jvtrigueros20:01:20

So before it used to be like this:

jvtrigueros20:01:44

I don't know if this is LSP or clj-kondo, but when I was using watchers it wouldn't change the syntax colouring but with LSP it removes it and just gives me the default text color.

jvtrigueros20:01:30

This is usually for things I gotta fix, but for macros like specter, I have to keep this around:

jvtrigueros20:01:27

I'll keep using the SNAPSHOT and see if there's any more differences. I just switched to the LSP version so I may miss some of the differences 😄

borkdude21:01:14

@jvtrigueros Don't know what's with the syntax colouring, but it seems clj-kondo has an issue with that macro. In that case you should / could use a config to get rid of those warnings.

jvtrigueros21:01:53

I’ll do that!