This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-12-19
Channels
- # adventofcode (18)
- # announcements (1)
- # babashka (153)
- # beginners (73)
- # bristol-clojurians (4)
- # calva (1)
- # cider (6)
- # clj-kondo (38)
- # clojure (154)
- # clojure-dev (12)
- # clojure-europe (7)
- # clojure-finland (11)
- # clojure-nl (70)
- # clojure-spec (13)
- # clojure-uk (101)
- # clojuredesign-podcast (2)
- # clojurescript (15)
- # core-async (30)
- # cryogen (1)
- # cursive (5)
- # devops (1)
- # duct (4)
- # figwheel-main (1)
- # fulcro (19)
- # jobs (12)
- # kaocha (17)
- # luminus (2)
- # malli (8)
- # music (5)
- # nrepl (13)
- # off-topic (20)
- # overtone (3)
- # re-frame (7)
- # reagent (38)
- # shadow-cljs (13)
- # specter (3)
- # tools-deps (6)
- # vim (7)
@borkdude from what I am gathering from here (https://github.com/borkdude/clj-kondo/commit/56e9a51bf1c87276e4ff9c928f5207d89f90dab7) clj-kondo should ignore the comments. Does that include (comment xxx)
? Because i think i'm still getting warnings for stuff inside such comments.
clojure.core/comment
sections are often used as REPL buffers for experimentation, that is why I want linting there
I agree, but I introduced now a clj-kondo on a big project with a LOT of warnings. So i'm turning off everything ( 😄 ) until i get everything green. Then refactor stuff and re-enable it so it keeps being green
ok that makes sense. what you can also do is lint the current stuff to a status-quo.txt file and then view the diff between new changes and that file
this is what I do myself in clj-kondo with new linters or changes to linters, to detect regressions
you can also leverage the EDN / JSON output for more intelligent diffing / nicer reports
I'll look into that. Also I've seen a very interesting GitHub action (https://github.com/marketplace/actions/clj-kondo-checks)
Maybe a new page called Build integration or CI integration would be nice, so we can add more stuff there
@borkdude something seems to not work with the github action (https://github.com/borkdude/clj-kondo/pull/669/checks?check_run_id=356139159 )
yeah, you can ignore that. it's something @delaguardo was looking into I think
Only with PRs from forked repositories
I understand that is a bit double, but you're integrating clj-kondo with their continuous integration process 😛 Maybe I can find a synonym
yeah, maybe it's fine as it is. I like it better than "Build integration" since CI is most often a remote thing whereas build can also be local
fwiw this is the Github actions config: https://github.com/borkdude/clj-kondo/blob/master/.github/workflows/clj-kondo.yml