Fork me on GitHub
#clj-kondo
<
2019-11-23
>
borkdude16:11:56

Clj-kondo v2019.11.23: unused imports, a working Windows binary (thank you GraalVM 19.3.0!) and a couple of improvements/bugfixes. https://github.com/borkdude/clj-kondo/releases/tag/v2019.11.23

Filipe Silva16:11:59

also released the npm package for that version, with support for the windows binary: https://github.com/filipesilva/clj-kondo

borkdude16:11:45

@filipematossilva Kewl! Did you test it on Windows?

Filipe Silva16:11:09

I have CI testing it on windows

borkdude16:11:19

"Run binary with no args" seems a lot faster

borkdude16:11:27

than the last Windows build, so that looks good

borkdude17:11:59

In Windows + VSCode with the @marc-omorain clj-kondo lint plugin installed and the NPM package, I get:

borkdude17:11:23

It works fine from the terminal:

borkdude17:11:26

Maybe it's just a matter of restarting VSCode. I'll try after dinner

Marc O'Morain17:11:17

I’m calling shelljs.which("clj-kondo") to check if it’s on the path.

borkdude17:11:54

does VSCode support running this in some JS console?

Marc O'Morain17:11:16

@pez might know. I think you can open the chrome console somehow.

borkdude17:11:43

When I open a terminal in VSCode, clj-kondo is there

borkdude17:11:39

not sure how I get access to shelljs from the browser console

borkdude17:11:47

I'll just try in development mode later

pez18:11:38

Definitely should be tracked down with the extension in dev mode.

borkdude19:11:56

It seems TypeScript forbids these debugging hacks...

littleli19:11:48

just for my curiosity, can you try:

vscode.window['which'] = which;

borkdude19:11:13

that also didn't work

Filipe Silva22:11:41

this looks like just a TS error

Filipe Silva22:11:07

you should be able to cast the object to any

Filipe Silva22:11:21

(vscode.window as any).which = which

borkdude19:11:59

Seems to magically work in dev mode:

borkdude19:11:27

So.. it works in development mode, but not when I install clojure-lint 0.5.0

borkdude19:11:10

@marc-omorain did you release the latest changes to the marketplace?

borkdude19:11:43

it doesn't appear so

Marc O'Morain19:11:12

i thought i did

Marc O'Morain19:11:19

I don’t know where to admin that 😄

borkdude19:11:30

There seem to be two commits after 0.5.0

borkdude19:11:29

I'll wait for the new release and then I'll give it a try again

borkdude19:11:57

I left my VM unattended for a minute:

pez19:11:35

That is Windows for me, @borkdude , waiting for it to update and install and whatever.

borkdude19:11:45

Hard crash again with VirtualBox, machine hard reboots

borkdude19:11:50

@marc-omorain Confirmed it works with 0.6.0:

borkdude19:11:07

> Small update. I've found if I reboot a VM from within Virtualbox it will crash. https://forums.virtualbox.org/viewtopic.php?f=8&amp;t=93739&amp;sid=49d1ab9315fc4d748021c2de56f31742&amp;start=30 Yup, that just happened to me

borkdude19:11:00

Anyway, happy it works. Thanks Marc!

borkdude19:11:17

@marc-omorain I guess you can remove > At this time, macOS and Linux are supported. Runing GraalVM on Windows has some issues. now

borkdude19:11:40

It might be nice to add the marketplace link to the repo

Marc O'Morain19:11:45

Good idea, I’ve done both now, and updated the changelog.

Marc O'Morain19:11:53

0.6.1 incoming

borkdude20:11:08

Thanks 🙂

borkdude20:11:20

So now we have 2 package managers for Windows that can install the clj-kondo binary and two VSCode plugins that support clj-kondo linting. Windows people have choices now 🙂

borkdude20:11:17

I guess it also works with Emacs on Windows now

borkdude20:11:31

alright, thanks a lot everybody who helped testing this

Marc O'Morain20:11:57

> Emacs on Windows shudder

practicalli-johnny09:11:36

I used Emacs on Windows (7 and 10) for a year at a bank. It’s not quite as snappy as on Linux but very usable. The biggest challenge was finding an Internet proxy that didn’t require Windows NTLM authentication. Once that was found, it was pretty smooth. I even forgot I was on Windows with Emacs on full screen

borkdude21:11:31

I actually used Emacs on Windows when I started to learn Clojure