I have just played around with the current type checking. Nice work. How can I define the type of my own functions?

hey @whilo. that's documented here: https://github.com/borkdude/clj-kondo/blob/master/doc/types.md please note that this format is WIP and might change (although I hope not too much and I will document changes)

Got a hello world version of clj-kondo.lsp working 🙂 Adding the real diagnostics can't be that hard now the plumbing is more or less there

@filipematossilva I'll probably publish the server part of clj-kondo.lsp using this: https://github.com/BrunoBonacci/lein-binplus It wraps an uberjar in a executable-like thing that works on any platform. Maybe that can also be used for the normal clj-kondo on Windows

ah I guess that's what clojure-lsp does?

yes that would work

I guess it ends up being the exact same thing as I'm doing, just one jar less

but I image your native images for osx/linux are still faster

yes, that wrapped jar executable would only be for Windows

until GraalVM sorts things out for Windows

FWIW windows user numbers are quite high, at least on the npm ecosystem

~50% of Angular users are on Windows for instance

I'm not downplaying the importance of Windows, I just don't know anything better right now 🙂

I think clj-kondo.lsp will help these users. The startup time for command line usage isn't much of an issue. It's the editor feedback that should be fast.

yes I know, just wanted to give perspective

I think there's a common perspective that windows users are a minority, but the reality ends up being different

I'd like to see Windows % in the next Clojure Survey

that's a tricky one

although it would be accurate for survey respondents, they might not accurately represent the population

does maven provide download stats per OS?

that might be a more accurate, if it can filter out CI machines

clj-kondo is published to clojars. not sure if it has those stats

@snoe Do you have Windows users of clojure-lsp? I just tried the lein bin plugin you're using with one of my own jars and it didn't run for me in a Windows VM

@borkdude there's been a couple, and I have a number of open issues around it, kinda hoping someone champions it cause it's difficult for me to get a handle on.

I'm experimenting with bundling a .jar file in a VSCode extension. I first tried the lein bin approach, but I got a 32-bit error in a Windows VM. java -jar does work

yeah, there's a few other older school things like jar2exe. I wanted to get ci running on azul to be able tot test them all

https://github.com/borkdude/clj-kondo.lsp/blob/cbed6cca096db346e9ee2e1951e680d688d52fbf/vscode-extension/src/extension.ts#L25

Is anyone using clj-kondo with Github actions and has that process documented?

@snoe I can help you get github actions working

it has windows CI too

https://github.com/filipesilva/clj-kondo is running on github actions to test

oh perfect

@dominicm do you mean just running clj-kondo on github actions for CI, or a github action that runs clj-kondo on your code?

I think he means the latter

that I have never done

@filipematossilva what does the latter mean? I think I meant the former.

the latter means making a github action that is triggered by some event in github and performs some piece of code, in this case clj-kondo

a common usage of github actions is to automatically add/remove labels in issues/prs

the former means adding a github actions for CI check to your commits, where a series of commands is ran and status is displayed on PRs

if you want the former, it is mostly a matter of - deciding what OS you want it to run on - deciding on a way to install clj-kondo on that run - running clj-kondo

I can help you setup that, can you point me to your repo?

I wouldn't want to put you out :) I just wanted to poke around and see how that looked in practice.

Looks like this

https://github.com/filipesilva/clj-kondo/actions

And this is the definition

https://github.com/filipesilva/clj-kondo/blob/master/.github/workflows/nodejs.yml