Fork me on GitHub
#clj-kondo
<
2019-09-17
>
gerred00:09:57

hmm on master

gerred00:09:08

i'm getting a bunch of "did not catch tag:" when I'm going through several libs

gerred00:09:44

so for next.jdbc for example, I'm getting that on: ResultSet, DataSource, Connection, ResultSetMetaData, Integer, java.io.Writer, java.sql.ResultSet, PrepaerdStatement

gerred00:09:04

it'd be nice to have a way to extend what tag-from-meta is switching over

borkdude06:09:42

yeah, sure, I forgot to delete that println

borkdude06:09:36

I'm continuing in the branch ret-types, but it's a work in progress. I'll report back here when it's a good time to check again!

borkdude09:09:55

the branch ret-types can be tested.

borkdude09:09:12

I have to clean up that branch some more, and then I'll merge to master

borkdude10:09:56

but you can test it right now if you want 🙂

gerred10:09:22

oh why not 😄

gerred10:09:41

need to make sure it works with linter-kondo anyway, right? 😉

🙏 4
borkdude10:09:44

one issue I struggled with is that ^String can be nilable, but some specs I wrote expected just a ::string. But to not create any false positives, I basically have to treat almost every type a nilable.

borkdude10:09:24

that's why (subs nil 1 10) now doesn't create a warning

borkdude10:09:21

it sucks, but at least you still get warning for (subs 1 2 3)

gerred10:09:53

that's fair.

robertfw18:09:02

It appears that within cond->, I'm not seeing unresolved symbol errors. I took a look through the issues on github but didn't spot anything related - is this a known problem, or would you like me to file a bug?

robertfw18:09:11

Appears to be both within the condition and the body

borkdude21:09:02

@robertfrederickwarner That's known, some macros aren't fully linted, because I just didn't get around to it yet. Will handle it in a future version.

borkdude21:09:48

@gerred I think the nil issue has been fixed now in the ret-types branch. Still have to do some cleaning/maybe optimizing

borkdude21:09:16

$ echo '(subs nil 1 1)' | clj-kondo --lint -
<stdin>:1:7: error: Expected: string, received: nil.
linting took 10ms, errors: 1, warnings: 0