Fork me on GitHub
#clj-kondo
<
2019-09-13
>
borkdude06:09:16

@gerred awesome! If you want, a PR which adds this to the editor integration docs would be cool

borkdude07:09:28

@gerred I think you are referring to linter-joker in a link, but the link says linter-joker (in the README of your package)

borkdude08:09:15

excited...

$ echo '(subs "foo" "bar")' | clj-kondo --lint -
<stdin>:1:13: error: Expected a natural integer but received a string.

🎉 4
wizard 4
gerred11:09:36

oops, looing at my README.

gerred11:09:41

heavily adapted by linter-joker 😄

gerred11:09:43

fixing that, thanks!

borkdude11:09:35

same for flycheck-clj-kondo, 99% based on flycheck-joker. thanks @roman.bataev

borkdude13:09:13

@gerred merged, thanks!

gerred18:09:37

I just made a github action as well for linting with clj-kondo as a check, built right into Github Actions. If anyone here is in the beta, I'm happy to share it with you while I polish it up for release.

gerred18:09:09

I'm working on having it comment on a PR review the exact lines where clj-kondo fails as well, so it's not just "fail the check, look at the logs and good luck"

gerred18:09:55

the only pain is I have to actually test it by PR-ing code that fails clj-kondo, so it's a little more geared for linting public projects that are taking in public PRs.

borkdude18:09:57

awesome idea. I'm not sure if I'm in the beta, how can I know?

gerred18:09:00

you also may want to sign up for github package registry:

gerred18:09:52

i just finished up a workflow to release master (and soon special tags) to our github package registry docker. would be happy to help do that for clj-kondo once you're in both.

gerred18:09:10

docker hub doesn't have robot accounts and it's 😿

borkdude18:09:41

sure, thanks

gerred18:09:26

pretty handy

borkdude18:09:27

yeah, I can also do that from CircleCI, but I've resisted making releases from master until now, because people will start to depend on it 😉

gerred18:09:41

yeah that's what we're moving from.

gerred18:09:52

because of the integration with multiple types of GH events and the package registry.

gerred18:09:24

you can listen on any built-in GH event, like issues/pull requests, comments, everything.

borkdude18:09:59

that's pretty sweet

gerred19:09:52

if this works how I think it does 😍

borkdude19:09:44

a lot of work to be done, but conceptually it works 🙂

borkdude22:09:14

I've added a few more functions like into, map, filter, keep, etc. Anyone wanna test?

borkdude22:09:08

do you prefer a binary for testing or do you want to clone the repo and run from a branch? it's relatively easy, just: clojure -A:clj-kondo --lint ...

gerred22:09:34

ya I'll just do that

gerred22:09:36

what's the branch?

gerred22:09:58

i have graal locally so I can even build the binary

borkdude22:09:34

if you set GRAALVM_HOME, then it's just script/compile for building