@borkdude why did you decide to use a .bat with lein as you mentioned here: https://github.com/taylorwood/clj.native-image/pull/9#issuecomment-497981891? like you, i shaved all of the yaks you seemed to, to get a deps.edn / native-image build to work w/ windows 10. was it that it seems to be less work for someone to replicate the lein / .bat approach?

mmm, actually, i thought i was using clj via compile, but no, compile resolves to compile.bat, and compile is a bash script and wouldn't have run anyway...sorry, for the noise.

@borkdude on a related note, regarding: https://github.com/taylorwood/clj.native-image/pull/9#issue-278357391 if the windows clj / clojure came with a standalone .exe / .com / .bat to launch the clojure-tooling implemented via powershell, do you think the lein / .bat approach would still be necessary?

@sogaiu I ran into too many issues with a GraalVM clj wrapper that a .bat was easier

@borkdude hmm...it seems like it's almost there though...you also filed TDEPS-128 iiuc...that one seems to imply that a standalone launcher for the clojure-tooling would be helpful. does that seem right?

yeah, almost, but that wasn’t the case when I worked on it 🙂

see #clj-on-windows

I think a GraalVM executable for clj/clojure would make sense

was just having similar thoughts within the last few hours :) but i don't envy the folks having to do the windows building! btw, i summarized related info here: https://gist.github.com/sogaiu/e079cd770051685c46ab24b6658effcf

nice, thanks

https://github.com/marcomorain/clojure-lint/blob/master/README.md

Version 0.1 published 🎉

https://user-images.githubusercontent.com/448001/59565149-79ad7780-9047-11e9-9dcf-d8776a2b0814.png

w00t!!! 😄 awesome!

how doth one install this extension?

I’m about to release a new version of clj-kondo. I’ll announce the extension together with it

There is a GUI for installing them. It’s named “Clojure-lint” (I hope!)

I renamed the repo. Pro tip: don’t do too much typing on a MacBook Pro.

The keyboard is terrible.

So I heard (>= 2016 models)

I’m preparing a new release and will announce your work together with it.

Thank you!

and thank you!

clj-kondo v2019.06.16-alpha! 🎉 major new features: - unresolved symbol detection - VSCode integration (thank you @marc-omorain !) https://github.com/borkdude/clj-kondo/releases/tag/v2019.06.16-alpha

@borkdude about the info level: https://github.com/marcomorain/clojure-lint/blob/de399b6fba3931649113b66754ac1dbd09d6ed42/src/extension.ts#L64 I was looking for an exhaustive list of levels in the Kondo source but I couldn’t spot it.

@marc-omorain That’s the only missing level

My stretch goal is to add “suppress this” as an auto fix, so that users can click on a warning, and i would create a minimal patch to their .clj-kondo/config.edn` will be made to suppress that warning.

That would be very nice.

vscode makes it simple to add actions to each diagnostic.

I would have to be extra careful not to break anything in the config format, which is my stretch goal 🙂

The action itself is the hard part 😭

Don’t worry about breaking the config format - extensions for vscode are simple to update, so I can react very quickly to any changes.

do you expect people to upgrade their extension e.g. once a week, or do they update automatically?

I was thinking of this feature: https://github.com/borkdude/clj-kondo/issues/253 so people know if something unexpected is in their config and they can upgrade, so I have more freedom to deprecate something (which I will try to avoid, but still)

(very much inspired by the CircleCI CLI)

Also, feel free to make a PR for the editor integration docs for VSCode (if I don’t beat you to it)

That’s really meta

Linting the config - I love it.

yeah, I might also add support for linting project.clj or deps.edn 🙂

@marc-omorain @borkdude clj-kondo in VSCode, sweet guys!!! 🎉