are you running kondo as a CI step to check style?

Is there some ready support or should I just use the API in a clojure.test to ensure no warnings are given?

@tatut there are already people using kondo in CI. apart from using a JVM, you can also call the binary and check the exit codes in a script for example

https://github.com/borkdude/clj-kondo/#exit-codes

you can also use JSON output and feed it to jq to script whatever you want, without using a JVM

running in JVM is easier as I don’t have to install anything on the CI machine

(deftest lint
  (let [result (clj-kondo/run! {:lint ["src/clj" "src/cljs" "src/cljc"]})
        {:keys [error warning]} (:summary result)
        ok? (= 0 error warning)]
    (is ok? "No lint warnings")
    (when-not ok?
      (clj-kondo/print! result))))

that simple test seems to do the trick

that should work yes

now I just have to fix all warnings 😅 …that’s the bigger issue in this large project

or just ignore the warnings and only count the errors. up to you 🙂

you can also disable certain linters for the time being

using the :config parameter

I may do an expected count and check that

ok, seems just checking errors at first would be a good first step

weird, I’m getting a parse error “no conversion to symbol” in one file, but it doesn’t seem to contain anything out of the ordinary… looks like it’s coming from the reader, not kondo though

looks like a namespaced map problem, if I have #:some.ns {:key "foo"} map in a cljs file, the parsing fails

writing it as {:some.ns/key "foo"} works

@tatut can you create a small repro foo.clj so when calling clj-kondo --lint foo.clj you get this problem?

putting only that expression in file does not reproduce it

it doesn’t seem to occur in the command line tool, only when running from my project jvm… perhaps I’m getting some wrong version from my other deps

hm, is another library of yours also using clj-kondo? I made a patch, for this in rewrite-clj but I’m not calling that patch in the JVM version

see: https://github.com/xsc/rewrite-clj/issues/54#issuecomment-493038733 it’s an issue in rewrite-clj

I don’t think so, but I’ll check my deps

requiring clj-kondo.impl.rewrite-clj-patch before calling clj-kondo should resolve the issue

that works

thanks

I think I should move that require from clj-kondo.main to clj-kondo.core, but it might interfere if people already use rewrite-clj in their projects

I think eastwood had the same trouble with dependency clashes when people used that in their JVM so they inlined all the deps. Maybe I should do that with rewrite-clj, but I don’t know how that works license-wise

made an issue for this here: https://github.com/borkdude/clj-kondo/issues/254

@tatut I'm using it with reviewdog