Fork me on GitHub
#clj-kondo
<
2019-06-10
>
lread02:06:01

And @borkdude thanks also for being on the defn podcast: https://soundcloud.com/defn-771544745/50-michiel-borkent-aka-borkdude It was a delightful and educational listen!

sogaiu06:06:00

@borkdude i am getting what look like some duplicate results when running clj-kondo (3797573ebe1dfb1689f819dcaa0777cd1060caa4) on https://github.com/weavejester/cljfmt/blob/3c6fbde59cd931972feafe73917866064c9d7b08/cljfmt/src/cljfmt/core.cljc

src/cljfmt/core.cljc:13:19: warning: namespace cljs.reader is required but never used
src/cljfmt/core.cljc:285:8: warning: unused binding sym
src/cljfmt/core.cljc:285:12: warning: unused binding alias-map
src/cljfmt/core.cljc:285:30: warning: unused binding args
linting took 77ms, errors: 0, warnings: 7
the last three warnings show up a second time in the :findings vector returned as a part of the map returned from the clojure api function run!

borkdude07:06:20

@sogaiu this is probably because a CLJC file is linted twice, once as Clj and once as Cljs. The unduplication happens in the print function, but should probably moved to an earlier stage, something I forgot when making the Clojure API

borkdude07:06:03

If you can make a ticket so I don’t forget, I’m on mobile

sogaiu07:06:12

@borkdude thanks, i will make an issue

dominicm09:06:50

I just ran into something that eastwood would flag as a "suspicious test" something like (t/is 5 4). Is this something clj-kondo is interested in catching?

sogaiu10:06:46

lol, finally figured out the name 🙂 very nice.