Hi there clj-commoner's, we (@kyle.gann and I) just opened a PR against https://github.com/clj-commons/iapetos/pull/64 to improve the collector performance quite extensively (we believe ~7x). What (if any) additional support can we provide to move this change forward?
Entirely reasonable, thanks for the responsiveness!
Thanks. Could I ask you to notify me here when you'd like a rereview? My GitHub notifications generally go to /dev/null
Hi @joe.lane, you can find the last known maintainers in https://github.com/clj-commons/iapetos/blob/master/.github/CODEOWNERS. So I expect @slipset or (hmm.... I'm not sure who MalloZup is on Slack...) might be able to help.
Nice, I had already reached out to Yannick but I didn't realize the CODEOWNERS had multiple maintainers in it
Oh yeah, Yannick was the original author who transferred iapetos to clj-commons. So he's not a maintainer anymore.
Got it. Ironic that github suggested him as the one to review the patch facepalm
Yeah. We might be abusing CODEOWNERS.
Yannick maybe should not be in there.
Hey @joe.lane. First of all thanks a lot for the PR. I have reviewed it, and left some comments. I’m not necessarily saying that your approach is not sound, it’s just that I’d appreciate a bit more convincing. Hope that’s ok.
@slipset will you be at conj later this month? Maybe we can have a 5 minute chat about this PR?
Unfortunately, I will not be at the Conj this year.
Ok. Maybe I'll find the time tonight if I’m lucky to respond to your feedback on the PR.