Clojurians Log v2
clj-commons 2023-12-21
@slipset are you able to take a look at the CI in https://github.com/clj-commons/hickory/commit/70d62f55d3c2a67869d092deb2bd23250d7521a1? The GitHub Actions bit is working, but CircleCI is failing
I’m happy to switch it all over to GitHub Actions if there is a deployment script for that.
I’m a bit busy right now, but I’ll try to have a look at it some time today. Please remind me tomorrow if I forget.
Think I’ve got it all fixed now, and I’ve pushed a 0.7.4 release (and deprecated 0.7.2 and 0.7.3)
I don’t understand why this deploy job ran in CircleCI - https://app.circleci.com/pipelines/github/clj-commons/hickory/79/workflows/05080a6f-9c85-4fc6-8712-c1382fdd7500/jobs/115. The https://github.com/clj-commons/hickory/blob/1ad9a1f7a40bea4e2528a06f87f9464f47b0a280/.circleci/config.yml#L15-L22 has a filter for tags. It’s been a while since I did Circle work, does anyone else have an idea?
not sure @danielcompton as i mostly use github actions these days, but maybe you have to ignore branches? https://discuss.circleci.com/t/workflow-job-filter-to-only-tags-not-working/40628
Yeah, I’m guessing that is the reason why we have https://github.com/clj-commons/hickory/blob/1ad9a1f7a40bea4e2528a06f87f9464f47b0a280/.circleci/config.yml#L137-L143, @borkdude?
That’s me.
I think @tiagomlalves did something to sort this out in clj-ssh
Check the commits on the circle config there
@danielcompton the reason is that CircleCI needs a rule for branches
this was a bit weird to me coming from GitHub Actions, but it’s well documented in CircleCI