clj-commons

oyakushev 2023-11-21T16:56:09.253039Z

Hey guys, could anyone take a look? https://github.com/clj-commons/potemkin/pull/75

seancorfield 2023-11-21T17:44:16.482409Z

Looks like a reasonable change to me. It seems odd to pull in a tuple library just for that one usage. In the memoize code I maintain, I just use the sequence of args as-is -- I wouldn't even bother unrolling them into a vector -- as I recall. But maybe that's the key to it being a "fast" memoize instead of the regular memoize?

oyakushev 2023-11-21T17:45:52.303659Z

My guess (without doing the benchmarks) is that the most "fast" comes from using a mutable map instead of PHM.

slipset 2023-11-21T19:07:55.739229Z

Merged

❤️ 1
Matthew Davidson 2023-11-22T06:04:34.111009Z

@slipset, do you want to cut the new release, since you merged? It looks like you and I are the only ones with potemkin deploy perms on clojars. I'll ask Zach if he can designate others as admins.

slipset 2023-11-22T06:18:43.579649Z

Yah, I can do that. Will be tonight (CET) though.

slipset 2023-11-23T10:50:37.095889Z

0.4.7 is out

🎉 2