hi, does anyone know the creator / people involved in https://github.com/metrics-clojure/metrics-clojure ? The project is important IMO and has not seen much activit. I would like to make some updates and for the project to be in an envirotnment where more people can contribute
Project was migrated: https://github.com/clj-commons/metrics-clojure/
will check it out in the next days to see about next steps. My initial goal would be to have deps.edn support and CI build
@eugen.stan Thanks. Don't forget CODEOWNERS and ORIGINATOR (per https://clj-commons.org/maintaining-projects.html )
yeah, I will go through that again when I start working. who is originator in this case ? ans also: we could make a checklist that lists all the things we need to have - easy to follow
Feel free to make a PR against https://github.com/clj-commons/clj-commons.github.io
According to git commits on that repo, sjl https://github.com/clj-commons/metrics-clojure/commit/856a8a081d886405a0b705c3215c775f175cb3c2
@seancorfield: do you want to be on CODEOWNERS ?
is there a format for the file ?
I think I found it https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
* @<githubusername>
And, no, I don't need to be in the metrics CODEOWNERS file (but thank you for checking).
ORIGINATOR is just the @<username> (without the *)
👍
@seancorfield: I see the source code is separate lein projects. I wonder if polylith might be a good option for this - all source in a single place + multiple libraries to publish
Weighing in with a couple of cents. YMMV, but I really enjoy being able to release new versions by creating a new release tag in Github. I’ve outlined some of my thoughts here http://slipset.github.io/posts/deploying-to-clojars
@eugen.stan Polylith is designed for multiple apps, not multiple libraries -- switching everything to deps.edn and having a master build.clj in the root would likely be a reasonable compromise tho'...
@slipset Yes, I have automated release/deployments based on creating a new release tag (& notes) in GitHub for all my projects now, using GH Actions.
nothing against lein - but I like experimenting with libs from git before I do a release. and I would like to avoid having to maintain 2 build options at the same time.
@seancorfield: can you share your setup. I think what @slipset has described is reasonable. I hope that some/more of clj-commons libraries will reach Linux distros 🙂
@seancorfield: if it is for all projects, I will try to figure it out
@eugen.stan Checkout the .github/workflows in next.jdbc or honeysql for examples.
thanks
I pushed ORIGINATOR and CODEOWNERS on main branch
would like to use main instead of master for the future
You can rename the branch directly in GH I think? Been a long time and I don't remember...
sure, let me try
I think the main branch needs to be ste in GH settings - which I don't have access to
Added you as a "maintainer" to that repo. LMK if that's enough.
no, I see the settings menu but I think changing default branch and branch protections needs higher access
I'm too busy to dig in right now, sorry. If you can figure out where in the docs it is explained how to rename the primary branch and link me to it, I'll do it later when I get time -- or at least figure out what access to give you...
with images
Ah, you've already created a main branch so we can no longer just rename master -> main
deleted the main branch
Done!
thanks
(I'm surprised that isn't available to "maintainers"... I guess only "admins" can do that?)
main branch is very important - if you can mess with that you could do all sorts of mischiefs
IMO we got an ok for metrics migration https://github.com/metrics-clojure/metrics-clojure/issues/146
I created an issue in clj-commons https://github.com/clj-commons/meta/issues/77
https://github.com/metrics-clojure/metrics-clojure/issues/145
Seems like it could be a candidate. Please ask on the project itself if they’re willing to transfer. If they’re willing or don’t respond I a reasonable timeframe, say a couple of weeks over there, please feel free to file an issue over on our meta repo to start the possible adoption process.
I believe that @michaelklishin is still active in the community.
thank you @slipset . Will do.
I've asked https://github.com/metrics-clojure/metrics-clojure/issues/146
We use the core part of this at work but haven't run into any specific issues with it. However, I'd be in favor of seeing the core part under clj-commons -- but I will note that it is essentially eight projects and at least a couple of them are really dead so perhaps it's time for a new project that wraps Coda Hale's metrics library and provides just the core functionality?
https://github.com/clj-commons/marginalia is now a clj-commons project!