clj-commons

Eugen 2023-11-02T08:19:15.868979Z

hi, does anyone know the creator / people involved in https://github.com/metrics-clojure/metrics-clojure ? The project is important IMO and has not seen much activit. I would like to make some updates and for the project to be in an envirotnment where more people can contribute

Eugen 2023-11-14T15:22:01.714839Z

Project was migrated: https://github.com/clj-commons/metrics-clojure/

Eugen 2023-11-14T15:22:42.667069Z

will check it out in the next days to see about next steps. My initial goal would be to have deps.edn support and CI build

seancorfield 2023-11-14T17:23:01.385159Z

@eugen.stan Thanks. Don't forget CODEOWNERS and ORIGINATOR (per https://clj-commons.org/maintaining-projects.html )

👍 1
Eugen 2023-11-14T17:25:50.611729Z

yeah, I will go through that again when I start working. who is originator in this case ? ans also: we could make a checklist that lists all the things we need to have - easy to follow

seancorfield 2023-11-14T17:26:59.420899Z

Feel free to make a PR against https://github.com/clj-commons/clj-commons.github.io

seancorfield 2023-11-14T17:28:57.931289Z

According to git commits on that repo, sjl https://github.com/clj-commons/metrics-clojure/commit/856a8a081d886405a0b705c3215c775f175cb3c2

Eugen 2023-11-14T19:21:19.276899Z

@seancorfield: do you want to be on CODEOWNERS ?

Eugen 2023-11-14T19:21:36.496909Z

is there a format for the file ?

seancorfield 2023-11-14T19:22:23.587989Z

* @<githubusername>

seancorfield 2023-11-14T19:22:44.077669Z

And, no, I don't need to be in the metrics CODEOWNERS file (but thank you for checking).

seancorfield 2023-11-14T19:23:20.781339Z

ORIGINATOR is just the @<username> (without the *)

Eugen 2023-11-14T19:24:06.560319Z

👍

Eugen 2023-11-14T19:49:51.100659Z

@seancorfield: I see the source code is separate lein projects. I wonder if polylith might be a good option for this - all source in a single place + multiple libraries to publish

slipset 2023-11-14T19:51:33.854219Z

Weighing in with a couple of cents. YMMV, but I really enjoy being able to release new versions by creating a new release tag in Github. I’ve outlined some of my thoughts here http://slipset.github.io/posts/deploying-to-clojars

seancorfield 2023-11-14T19:56:43.795909Z

@eugen.stan Polylith is designed for multiple apps, not multiple libraries -- switching everything to deps.edn and having a master build.clj in the root would likely be a reasonable compromise tho'...

👍 1
seancorfield 2023-11-14T19:57:39.581599Z

@slipset Yes, I have automated release/deployments based on creating a new release tag (& notes) in GitHub for all my projects now, using GH Actions.

Eugen 2023-11-14T20:00:41.833659Z

nothing against lein - but I like experimenting with libs from git before I do a release. and I would like to avoid having to maintain 2 build options at the same time.

Eugen 2023-11-14T20:01:30.898189Z

@seancorfield: can you share your setup. I think what @slipset has described is reasonable. I hope that some/more of clj-commons libraries will reach Linux distros 🙂

Eugen 2023-11-14T20:02:56.234039Z

@seancorfield: if it is for all projects, I will try to figure it out

seancorfield 2023-11-14T20:09:53.988659Z

@eugen.stan Checkout the .github/workflows in next.jdbc or honeysql for examples.

Eugen 2023-11-14T20:10:08.987589Z

thanks

Eugen 2023-11-14T20:10:27.912029Z

I pushed ORIGINATOR and CODEOWNERS on main branch

Eugen 2023-11-14T20:10:52.933439Z

would like to use main instead of master for the future

seancorfield 2023-11-14T20:11:49.549729Z

You can rename the branch directly in GH I think? Been a long time and I don't remember...

Eugen 2023-11-14T20:12:01.417849Z

sure, let me try

Eugen 2023-11-14T20:16:08.773139Z

I think the main branch needs to be ste in GH settings - which I don't have access to

seancorfield 2023-11-14T20:20:16.932279Z

Added you as a "maintainer" to that repo. LMK if that's enough.

Eugen 2023-11-14T20:23:33.772819Z

no, I see the settings menu but I think changing default branch and branch protections needs higher access

seancorfield 2023-11-14T20:26:00.864119Z

I'm too busy to dig in right now, sorry. If you can figure out where in the docs it is explained how to rename the primary branch and link me to it, I'll do it later when I get time -- or at least figure out what access to give you...

Eugen 2023-11-14T20:29:20.330389Z

with images

seancorfield 2023-11-14T20:33:42.282999Z

Ah, you've already created a main branch so we can no longer just rename master -> main

Eugen 2023-11-14T20:37:35.505559Z

deleted the main branch

seancorfield 2023-11-14T20:38:42.378599Z

Done!

Eugen 2023-11-14T20:38:48.040429Z

thanks

seancorfield 2023-11-14T20:39:35.691569Z

(I'm surprised that isn't available to "maintainers"... I guess only "admins" can do that?)

Eugen 2023-11-15T04:03:20.209009Z

main branch is very important - if you can mess with that you could do all sorts of mischiefs

Eugen 2023-11-13T16:52:10.528019Z

IMO we got an ok for metrics migration https://github.com/metrics-clojure/metrics-clojure/issues/146

Eugen 2023-11-13T16:57:11.209629Z

I created an issue in clj-commons https://github.com/clj-commons/meta/issues/77

slipset 2023-11-02T08:31:57.177059Z

Seems like it could be a candidate. Please ask on the project itself if they’re willing to transfer. If they’re willing or don’t respond I a reasonable timeframe, say a couple of weeks over there, please feel free to file an issue over on our meta repo to start the possible adoption process.

slipset 2023-11-02T08:32:46.714109Z

I believe that @michaelklishin is still active in the community.

Eugen 2023-11-02T08:32:50.682119Z

thank you @slipset . Will do.

Eugen 2023-11-02T08:40:09.497829Z

I've asked https://github.com/metrics-clojure/metrics-clojure/issues/146

seancorfield 2023-11-02T16:44:53.945289Z

We use the core part of this at work but haven't run into any specific issues with it. However, I'd be in favor of seeing the core part under clj-commons -- but I will note that it is essentially eight projects and at least a couple of them are really dead so perhaps it's time for a new project that wraps Coda Hale's metrics library and provides just the core functionality?

seancorfield 2023-11-02T23:46:32.006429Z

https://github.com/clj-commons/marginalia is now a clj-commons project!

🎉 9