Fork me on GitHub
#clj-commons
<
2023-11-02
>
Eugen08:11:15

hi, does anyone know the creator / people involved in https://github.com/metrics-clojure/metrics-clojure ? The project is important IMO and has not seen much activit. I would like to make some updates and for the project to be in an envirotnment where more people can contribute

slipset08:11:57

Seems like it could be a candidate. Please ask on the project itself if they’re willing to transfer. If they’re willing or don’t respond I a reasonable timeframe, say a couple of weeks over there, please feel free to file an issue over on our meta repo to start the possible adoption process.

slipset08:11:46

I believe that @U066SRGEM is still active in the community.

Eugen08:11:50

thank you @U04V5VAUN . Will do.

seancorfield16:11:53

We use the core part of this at work but haven't run into any specific issues with it. However, I'd be in favor of seeing the core part under clj-commons -- but I will note that it is essentially eight projects and at least a couple of them are really dead so perhaps it's time for a new project that wraps Coda Hale's metrics library and provides just the core functionality?

Eugen15:11:42

will check it out in the next days to see about next steps. My initial goal would be to have deps.edn support and CI build

seancorfield17:11:01

@U011NGC5FFY Thanks. Don't forget CODEOWNERS and ORIGINATOR (per https://clj-commons.org/maintaining-projects.html )

👍 1
Eugen17:11:50

yeah, I will go through that again when I start working. who is originator in this case ? ans also: we could make a checklist that lists all the things we need to have - easy to follow

Eugen19:11:19

@U04V70XH6: do you want to be on CODEOWNERS ?

Eugen19:11:36

is there a format for the file ?

seancorfield19:11:23

* @<githubusername>

seancorfield19:11:44

And, no, I don't need to be in the metrics CODEOWNERS file (but thank you for checking).

seancorfield19:11:20

ORIGINATOR is just the @<username> (without the *)

Eugen19:11:51

@U04V70XH6: I see the source code is separate lein projects. I wonder if polylith might be a good option for this - all source in a single place + multiple libraries to publish

slipset19:11:33

Weighing in with a couple of cents. YMMV, but I really enjoy being able to release new versions by creating a new release tag in Github. I’ve outlined some of my thoughts here http://slipset.github.io/posts/deploying-to-clojars

seancorfield19:11:43

@U011NGC5FFY Polylith is designed for multiple apps, not multiple libraries -- switching everything to deps.edn and having a master build.clj in the root would likely be a reasonable compromise tho'...

👍 1
seancorfield19:11:39

@U04V5VAUN Yes, I have automated release/deployments based on creating a new release tag (& notes) in GitHub for all my projects now, using GH Actions.

Eugen20:11:41

nothing against lein - but I like experimenting with libs from git before I do a release. and I would like to avoid having to maintain 2 build options at the same time.

Eugen20:11:30

@U04V70XH6: can you share your setup. I think what @U04V5VAUN has described is reasonable. I hope that some/more of clj-commons libraries will reach Linux distros 🙂

Eugen20:11:56

@U04V70XH6: if it is for all projects, I will try to figure it out

seancorfield20:11:53

@U011NGC5FFY Checkout the .github/workflows in next.jdbc or honeysql for examples.

Eugen20:11:27

I pushed ORIGINATOR and CODEOWNERS on main branch

Eugen20:11:52

would like to use main instead of master for the future

seancorfield20:11:49

You can rename the branch directly in GH I think? Been a long time and I don't remember...

Eugen20:11:01

sure, let me try

Eugen20:11:08

I think the main branch needs to be ste in GH settings - which I don't have access to

seancorfield20:11:16

Added you as a "maintainer" to that repo. LMK if that's enough.

Eugen20:11:33

no, I see the settings menu but I think changing default branch and branch protections needs higher access

seancorfield20:11:00

I'm too busy to dig in right now, sorry. If you can figure out where in the docs it is explained how to rename the primary branch and link me to it, I'll do it later when I get time -- or at least figure out what access to give you...

Eugen20:11:20

with images

seancorfield20:11:42

Ah, you've already created a main branch so we can no longer just rename master -> main

Eugen20:11:35

deleted the main branch

seancorfield20:11:35

(I'm surprised that isn't available to "maintainers"... I guess only "admins" can do that?)

Eugen04:11:20

main branch is very important - if you can mess with that you could do all sorts of mischiefs