Clojurians Log v2
clj-commons
This one could get some love https://github.com/clj-commons/claypoole/pull/66
I glanced over it, but I'm not knowledgable enough about clj-kondo to give a proper review.
@vemv It looks like the cjl-kondo configs have a double-nesting under resources which doesn't seem right...?
For next.jdbc, the path is https://github.com/seancorfield/next-jdbc/tree/develop/resources/clj-kondo.exports/com.github.seancorfield/next.jdbc
IDK anything about the PR in question, I just thought I'd draw attention to it
Ah, well, as it stands, it's not correct in structure...
I added a comment to the PR. We'll see what @grzm says.
I'm regenerating the list of https://clj-commons.org/projects.html since it's quite outdated, and I'm discovering several projects do not have ORIGINATOR and/or .github/CODEOWNERS files, so I'm adding those as I run across them.
If I add either file to a project you maintain, can y'all please check that I got it right?
And if you maintain a project that doesn't have either of those files and want to add them "right now" to save me some time, that would be appreciated 🙂
One thing we discovered is CODEOWNERS always get invited to review PRs. We found this spammy and employed https://github.com/clj-commons/rewrite-clj/commit/c4ef0cac1082364c3c9c809c5893154bc981e3f9 to avoid the spam.
I just noticed that... but I'm taking the stance that if no one bothered to add CODEOWNERS and they get pinged about it, they can always update the file to avoid that. I'm kind of annoyed that I can't regenerate the list of projects right now because these supposedly mandatory files (from a clj-commons p.o.v.) do not exist 😆
Some projects have CODEOWNERS but don't have ORIGINATOR -- which is less controversial to add
I think all the projects I'm involved in have CODEOWNERS, but some might be missing ORIGINATOR. I'll do a sweep.
And while I have your attention @lee you are one of the owners for Etaoin -- who is the originator?
nm, found it.
So far: kibit, seesaw, etaoin. Next up: hickory.
Ok, I'll do clj-http-lite...
@seancorfield is ORIGINATOR who it was last transferred from? clj-http-lite was transferred from martinklepsch who forked hiredman who forked from dakrone
I think ORIGINATOR is meant to credit the original author of the project when it got started?
Oh ORIGINATOR is not a GitHub concept, right? It is a clj-commons convention?
So for clj-http-lite probably hiredman, he forked from clj-http to create the first lite version.
Ok, I think all the projects I deal with are good.
Ah, I didn't know how clj-http-lite was related to clj-http... thanks!
The generator code for projects.html needed a few tweaks (e.g., it didn't support # comments in CODEOWNERS) but I have re-generated the file now, after adding missing ORIGINATOR and .github/CODEOWNERS files to every repo -- and for the repos I touched, I updated .gitignore to appropriately ignore clj-kondo/lsp/portal transient files (caches, ports).
point_up::skin-tone-2 This may well cause you -- as a "code owner" -- to start getting notifications for PR reviews etc. If you do not want to be invited for that, you can edit .github/CODEOWNERS and move yourself from the * line to a new line starting with .github/CODEOWNERS -- see https://github.com/clj-commons/pomegranate/blob/master/.github/CODEOWNERS for an example.