Clojurians Log v2
Clojure programming
Channels
Apps
clj-commons
jumar 2022-04-21T05:44:37.199019Z
I opened a PR: https://github.com/clj-commons/friend/pull/5 I want to test it on our app but at least the tests are passing (note that they weren't working at all because of missing dependency on ring-jetty-adapter)
jumar 2022-04-21T12:39:07.333629Z
I tested it on the app and together with updated config for ring-defaults it works as expected.
See the UPDATE: ring-defaults vs relative redirects section in the PR description.
jumar 2022-04-24T08:05:11.133699Z
@slipset let me know if I can do anything to make it easier for you to review. I'd like get this fix to our product as soon as possible 🙂.
slipset 2022-04-24T09:32:22.598309Z
Sorry, @jumar it's been a very busy couple of days. I'll get through it today.
jumar 2022-04-24T09:43:09.752069Z
👍
slipset 2022-04-24T09:43:52.688109Z
Reviewed. Small nitpics. Give me a ping when you’ve fixed it and I’ll merge and release?
jumar 2022-04-24T09:55:15.089769Z
Thanks a lot. They should be fixed now.
slipset 2022-04-24T13:09:56.533819Z
slipset 2022-04-24T14:02:27.164839Z
Thank you for following me up @jumar. Much appreciated!
jumar 2022-04-24T17:06:03.220969Z
Excellent, thanks a ton for the quick turnaround!