Fork me on GitHub
#clj-commons
<
2022-04-21
>
jumar05:04:37

I opened a PR: https://github.com/clj-commons/friend/pull/5 I want to test it on our app but at least the tests are passing (note that they weren't working at all because of missing dependency on ring-jetty-adapter)

jumar12:04:07

I tested it on the app and together with updated config for ring-defaults it works as expected. See the UPDATE: ring-defaults vs relative redirects section in the PR description.

jumar08:04:11

@U04V5VAUN let me know if I can do anything to make it easier for you to review. I'd like get this fix to our product as soon as possible 🙂.

slipset09:04:22

Sorry, @U06BE1L6T it's been a very busy couple of days. I'll get through it today.

slipset09:04:52

Reviewed. Small nitpics. Give me a ping when you’ve fixed it and I’ll merge and release?

jumar09:04:15

Thanks a lot. They should be fixed now.

slipset14:04:27

Thank you for following me up @U06BE1L6T. Much appreciated!

jumar17:04:03

Excellent, thanks a ton for the quick turnaround!