clj-commons

lread 2021-01-28T19:20:20.012Z

Thanks for your help @slipset, I https://codecov.io/gh/clj-commons/rewrite-clj! And thanks @borkdude for the warning on PR comments, I configure those to off.

slipset 2021-01-28T19:20:49.012300Z

Nice!

slipset 2021-01-28T19:22:40.012600Z

Would you need to do this? https://docs.codecov.io/docs/fixing-paths

lread 2021-01-28T19:34:17.014300Z

@slipset I don’t see an issue there for rewrite-clj, are you seeing a prob I might be missing? I use a kaocha plugin which uses cloverage. All the hard work is done by kaocha and cloverage for me.

slipset 2021-01-28T19:35:58.015Z

I would expect to see some clojure code with some red/green/yellow stuff on it.

slipset 2021-01-28T19:36:11.015100Z

lread 2021-01-28T19:37:34.016400Z

Ah thanks, I get the expected results on my screen from that URL, I shall take a deeper peek!

slipset 2021-01-28T19:38:31.016700Z

It’s not very important πŸ™‚

lread 2021-01-28T19:42:03.017500Z

Maybe not to you! simple_smile

lread 2021-01-28T19:43:58.018600Z

But in general code coverage is not crazy important to me, but I do find the info interesting.

borkdude 2021-01-28T19:45:20.020200Z

Test coverage can be a misleading metric. Such tools are only useful if you are doing something with this information, but how you should read these metrics is an art on its own. As such, I don't give it much value.

lread 2021-01-28T19:45:37.020400Z

@slipset URL you shared is working for me without being logged in now, maybe http://codecov.io was just getting its act together.

slipset 2021-01-28T19:45:59.020700Z

Works now for me as well!

πŸŽ‰ 1
borkdude 2021-01-28T19:49:43.022500Z

I agree it can be useful to find out which functions were never hit.