clj-commons

qerub 2020-08-03T20:22:15.016200Z

@borkdude: You seem to have experience with Circle CI. So I added the missing webhook the other day, but now I get a check stuck in "pending" ("ci/circleci: build Pending — Your tests are queued behind your running builds") for new PRs. Can you have a look at https://github.com/clj-commons/camel-snake-kebab/pull/68?

qerub 2020-08-03T20:24:29.016700Z

The "workflow" check appeared after I manually triggered a rerun.

borkdude 2020-08-03T20:37:27.016900Z

I now clicked re-run workflow in CircleCI

borkdude 2020-08-03T20:38:45.017100Z

CircleCI reports all successes here: https://circleci.com/gh/clj-commons/camel-snake-kebab/tree/use-clojure.string-split

borkdude 2020-08-03T20:40:45.017700Z

I also now enabled "Build forked PRs" and "Github status updates" here: https://circleci.com/gh/clj-commons/camel-snake-kebab/edit#advanced-settings

borkdude 2020-08-03T20:41:42.018Z

I will click re-run workflow once again

borkdude 2020-08-03T20:42:54.018500Z

@qerub Now it looks ok. I think "Github status updates" did the trick

borkdude 2020-08-03T20:44:13.018700Z

I also merged the PR for you

qerub 2020-08-03T20:47:48.019Z

@borkdude: Great, thank you.

qerub 2020-08-03T20:58:55.019300Z

I find this pretty confusing:

user=> (if-let [[first & rest] nil] :t :f)
:f
user=> (if-let [[first & rest] []] :t :f)
:t

Alex Miller (Clojure team) 2020-08-03T21:00:23.019500Z

it's actually pretty useful that they're different - the if condition here applies to the :as (the whole data structure)

Alex Miller (Clojure team) 2020-08-03T21:01:48.020200Z

if you want what it looks like you want, use seq

Alex Miller (Clojure team) 2020-08-03T21:02:03.020800Z

(if-let [[first & rest] (seq x)] ...)

qerub 2020-08-03T21:05:11.021400Z

@alexmiller: Thanks, you cleared up my confusion.