Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2023-12-05

Channels

#clerk
<
2023-12-05
>
elken08:12:04

I'm on io.github.nextjournal/clerk {:git/sha "e8f275b5cf077ec9441e404c1885ff0b6ee0aef9"} and I've noticed I'm suddenly having issues with exception/error reporting. I rarely get the expected error popup until I restart my serve process, otherwise I get a blank notebook. I've recorded a sample below (spoilers for aoc day 5, for trivial cases it seems to be fine. Also bear with the loading, I think it's because I was also capturing the video) No errors in the browser console other than it trying to render a null element

Andrea10:12:59

hi @U043RSZ25HQ. Unfortunately I cannot reproduce this issue with the same clerk version. I’m causing the same exception (assoc on cons) but the error message renders as expected when the expression is evaluated. Maybe we need more context to reproduce, or the notebook source...

elken10:12:06

Sure, my repo is https://github.com/elken/aoc; I can replicate it with pretty much any notebook, I randomly picked 2023/day04 and changed one of the functions to be an invalid symbol and it triggered. Huh, interesting note that I have a block at the start of all my solution notebooks to pull the problem HTML from AOC; if I comment that out it seems to work fine...

Andrea10:12:38

ok, thanks!

Andrea13:12:35

I think we were able to reproduce the issue, thank you for reporting

elken13:12:06

Great! 😄

Andrea16:12:20

Not merged yet, but that’d be great if you could give "eb89e0b2e9edf8937c7c4a14c6df0ebc3217adeb" a spin and see if it still reproduces?

elken16:12:31

Sure thing!

🙏 1
elken16:12:18

Seems to be fixed! What was it in the end?

Andrea16:12:05

when catching exception we’d leave garbage in the data which we send to the client

Andrea16:12:41

thanks for testing out!

elken16:12:13

Ahh, makes sense actually. Thanks for such a swift resolution 😄

elken16:12:08

Seems to still work fine, but it points out that stack trace CSS might need some changes for larger displays 😄

mkvlr18:12:09

@U043RSZ25HQ thanks for checking! And come color adjustments.

elken19:12:33

I'm overriding some of them in CSS, but yeah the stack trace parent just needs an overflow like this (maybe some padding so the scrollbar doesn't overlap)

👍 1