That error indicates clojures agent send-off/future threadpool has been shutdown

Typically as a result of calling shutdown-agents

hey @jkrasnay, I can reproduce the issue, taking a look

can also repro it with just the clerk repo and it seems to be related to running with -M: this fails:

mk@mkstudio ~/d/clerk (main)> clj -M:nextjournal/clerk nextjournal.clerk/serve! --browse
Clerk webserver started on  ...

mk@mkstudio ~/d/clerk (main)> clj -X:nextjournal/clerk nextjournal.clerk/serve! :browse true
Clerk webserver started on  ...
Clerk evaluated 'file:/Users/mk/dev/clerk/src/nextjournal/clerk/home.clj' in 2144.897625ms.

@borkdude do you maybe have an idea? We get this error regarding agents when we start via -M (and babashka cli) but it works with -X.

👀

can try this on both clerk and clerk-demo repos

@U5H74UNSF So just run clj -M:nextjournal/clerk nextjournal.clerk/serve! --browse on clerk and then I should see an error?

@borkdude yes, correct. Just verified it once more here that I do see the error

What I'm seeing is:

clj -M:nextjournal/clerk nextjournal.clerk/serve! --browse
Clerk webserver started on  ...

yes, the error should be in the browser that opens

> Unhandled java.util.concurrent.RejectedExecutionException > Task java.util.concurrent.FutureTask@78d3d660[Not completed, task = clojure.core$binding_conveyor_fn$fn__5823@6a9a4b8c] rejected from java.util.concurrent.ThreadPoolExecutor@2f6867d1[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]

I just get a blank screen

any local changes?

not to clerk itself

to the deps.edn?

storage.clerk.garden/nextjournal/clerk-assets@3Y9hSHm7RtAcnVHB3dfLn3raLZM1/viewer.js?immutable=true:1     Failed to load resource: the server responded with a status of 404 ()
'nextjournal.clerk.home:425 Uncaught ReferenceError: nextjournal is not defined
    at 'nextjournal.clerk.home:425:609

yeah

I'll try from main

yeah blank screen is if the js isn’t loading

because of a different hash (can happen with local modifications to the deps.edn)

I'll make a PR

found it already?

It's expected behavior, just wait for PR

https://github.com/nextjournal/clerk/pull/520

maybe I'm misunderstanding btw. if you --browse, what is the normal behavior, should the JVM exit?

thanks

should not exit

think we should barf the form out

what form?

the form you added, so it also doens’t exit when you don’t pass browse

so this CLI never has to exit

serve! starts a server, so no

build! should exit when it’s done

ok. I think if you would install clerk as a -T it would probably give the same problem

but -X doesn't shutdown agents, -T does

so we should probably always wait, instead of exit, regardless of bb.cli

hmm

if we call it interactively, we don’t want to wait

pushed the improvement

right, this is the shit with CLI functions, you can't always re-use them as composable functions

so maybe split it into two separate functions then

or add an extra parameter --wait false or so

hmm

so if we check for the bb.cli case we would have a problem with -T

not sure if anyones using clerk as a tool, what would be the use case?

did anything change recently regarding this? Wondering why we never ran into it until now

I'd expect so, but I'm trying:

clj -T nextjournal.clerk/serve! :browse true

I'll check into the -T implementation

the other thing also didn’t exit, maybe because it starts daemon threads in the meantime?

aha:

* **1.10.3.933 on July 28, 2021**
  * **TDEPS-198 - on -X, don't use System/exit or shutdown-agents (but don't let agent threads block exit)**
* 1.10.3.929 on July 21, 2021
* 1.10.3.912 on July 15, 2021
  * On -X success, exit with (shutdown-agents) instead of System/exit

I guess I'll have to change this in babashka.cli as well then

there’s the spreadsheet https://clojure.atlassian.net/browse/TDEPS-198 🙃

So:

On startup: make future/agent threadpool into non-daemon threads

this is in babashka.cli?

no, this is the chosen direction of TDEPS-198

which I'm now trying to implement. But using a local/root dep changes the deps.edn so I can't just launch it

yes, need to set "-Dclerk.resource_manifest={\"/js/viewer.js\" \"/js/viewer.js\"}"

grabbing the value, one sec

so with "-Dclerk.resource_manifest={\"/js/viewer.js\" \"\"}" it should work

seems to work :-D

huh, so with this I can then bump cli instead of making a change to clerk?

yes, after I publish a new version of cli

excellent, thank you!

Updated https://github.com/nextjournal/clerk/pull/520: the only change is upgrading babashka.cli

thank you, merged!

Works. Thanks for the quick fix!

thanks for reporting the bug!