Heads up - CIDER 14th birthday is on Friday, so right now Iām targeting this as the date for the upcoming 2.0 release. Feedback on the current snapshot and all the improvements and new features there is much appreciated!
Your baby's all grown up Bug! I am always so impressed and in awe of the dedication it takes for you and the rest of the contributors to maintain one of the best toolsets in programming (IMHO). Keep up the good work mate.
https://github.com/clojure-emacs/cider/pull/3964/changes#diff-261fa1b914c143218f2bd641c7ee07d11db500e08100a81a54ebb59440816192R147 Clojure's official references consistently call this the 'discard' reader macro - maybe we should follow that terminology? https://clojure.org/guides/weird_characters#_discard https://github.com/edn-format/edn/blob/master/README.md#discard (To be fair clojure-mode also calls it 'ignore' - if we prefer maintaining a convention across packages)
https://github.com/clojure-emacs/cider/pull/4068/changes/237faf4bbeae254cda47b0cdcc38b14f208dfaee seems like a bit of a misguided change if the semantics are 'color palette cycling' - in this context there's nothing wrong with hardcoded hex strings IMO. Having them inherit font-lock-* faces assumes that they're differentiated by colour - which is often not the case on monochrome-ish themes which lean on other channels like weights, italics, underlines etc, which can end up looking misleading. Same with the nrepl message colors https://github.com/clojure-emacs/cider/pull/4067/changes/0be76756d2c427cbdbd1cb8d35309a2cb710b5ea
I changed those mostly so it'd be easier to set them in color themes, but I don't feel strongly about this.
I'm on the fence when it comes to ignore and discard - I tried to stick with what we used so far, but I acknowledge that discard is probably the better term for this.
I'll think about both items.
I've push a couple of small changes that should address your concerns.