looks related to the creation of a new classpath in this function https://github.com/clojure-emacs/enrich-classpath/blob/f3244ba4ff2282e5ac30a701fa38b0944d75eb00/tools.deps/src/cider/enrich_classpath/clojure.clj#L18 not taking into account this clojure classpath overrides

will take a deeper look at it in a couple of hours

I'm pretty sure I fixed precisely that at some point

https://github.com/clojure-emacs/enrich-classpath/blob/f3244ba4ff2282e5ac30a701fa38b0944d75eb00/tools.deps/test/integration/cider/enrich_classpath/clojure.clj#L120-L129

Given you're not running cider-nrepl latest, maybe you're not running cider latest either? Or try to determine the enrich-cp version

I was running with 1.19.0

dang, but now I can't reproduce, with the latest

so I guess it is fixed

@UM4CBJVLZ can you try with the latest cider, it looks like it is fixed there

Yes, will do and report here

This ended up being my startup log :

;; Connected to nREPL server - 
;; CIDER 1.14.0-snapshot (package: 20240421.1419), nREPL 1.1.1
;; Clojure 1.11.2-4, Java 17.0.10
;;     Docs: (doc function-name)
;;           (find-doc part-of-name)
;;   Source: (source function-name)
;;  Javadoc: (javadoc java-object-or-class)
;;     Exit: <C-c C-q>
;;  Results: Stored in vars *1, *2, *3, an exception in *e;
;;  Startup: bash /home/jmonetta/.emacs.d/elpa/cider-20240421.1419/clojure.sh /usr/local/bin/clojure -Sdeps \{\:deps\ \{nrepl/nrepl\ \{\:mvn/version\ \"1.1.1\"\}\ cider/cider-nrepl\ \{\:mvn/version\ \"0.47.0\"\}\ refactor-nrepl/refactor-nrepl\ \{\:mvn/version\ \"3.10.0\"\}\}\ \:aliases\ \{\:cider/nrepl\ \{\:main-opts\ \[\"-m\"\ \"nrepl.cmdline\"\ \"--middleware\"\ \"\[flow-storm.nrepl.middleware/wrap-flow-storm\,refactor-nrepl.middleware/wrap-refactor\,cider.nrepl/cider-middleware\]\"\]\}\}\} -M:dev:cider/nrepl

oh, but I run it again after changing some deps and now :

;; Connected to nREPL server - 
;; CIDER 1.14.0-snapshot (package: 20240421.1419), nREPL 1.1.1
;; Clojure 1.11.1, Java 17.0.10
;;     Docs: (doc function-name)
;;           (find-doc part-of-name)
;;   Source: (source function-name)
;;  Javadoc: (javadoc java-object-or-class)
;;     Exit: <C-c C-q>
;;  Results: Stored in vars *1, *2, *3, an exception in *e;
;;  Startup: bash /home/jmonetta/.emacs.d/elpa/cider-20240421.1419/clojure.sh /usr/local/bin/clojure -Sdeps \{\:deps\ \{nrepl/nrepl\ \{\:mvn/version\ \"1.1.1\"\}\ cider/cider-nrepl\ \{\:mvn/version\ \"0.47.0\"\}\ refactor-nrepl/refactor-nrepl\ \{\:mvn/version\ \"3.10.0\"\}\}\ \:aliases\ \{\:cider/nrepl\ \{\:main-opts\ \[\"-m\"\ \"nrepl.cmdline\"\ \"--middleware\"\ \"\[flow-storm.nrepl.middleware/wrap-flow-storm\,refactor-nrepl.middleware/wrap-refactor\,cider.nrepl/cider-middleware\]\"\]\}\}\} -M:dev:cider/nrepl

The deftests above are easy to extend with real and isolated deps.edn files, feel free to contribute a repro

(no fix expected - should be easy for me)

this dep is what seems to break it :

io.github.nubank/morse {:git/tag "v2023.10.06.02" :git/sha "88b5ff7"}

ok, please contribute a full deps.edn in the issue tracker (or PR if you will)

sure, I'll take a deeper look after lunch and try to figure it out

FWIW I also confirm that the bug is still present after updating to last cider version.

I already figured out the issue, trying to fix it now

ok, created https://github.com/clojure-emacs/enrich-classpath/pull/63

it works for me after that change

the problem shows up when we use libs with git coordinates

added a small description of the issue on the PR desc

there are also some possibly problematic lines, like this https://github.com/clojure-emacs/enrich-classpath/blob/master/tools.deps/src/cider/enrich_classpath/clojure.clj#L123 which only add exclusions to maven libs

Let's just say that clojure.clj is not my most favorite program 😄 it was simpler originally... Any fix with a repro that can be run in the existing test suite can be merged.

I just updated the tests, testing to see it still works

and it didn't, some timed-out test is failing :thinking_face:

what test are you running? Only focus on the tools.deps dir

was running everything, running only tools.deps now

ok, done @U45T93RA6, amended the commit with the updated test

Thanks for the PR! I've initiated its release process.

We got a Clojars deployment whoopsie so we'll have to wait ~1d till it's all available (you can (setq cider-enrich-classpath nil) in the meantime)

Enrich 1.19.2 is now released. CIDER latest (Git master or melpa unstable) already includes it

Hi 👋 You could remove the out middleware from cider-nrepl's default middleware stack - should work

Thanks, I’ll give it a try.