Fork me on GitHub
#cider
<
2022-01-03
>
bozhidar10:01:19

FYI - the helm-cider issue has been fixed and a new version (0.5) is out. I had completely forgotten about this package to be honest. In general it's a bad idea to rely on private compatibility workarounds. At any rate - I'm glad we finally removed the last of them. Life is easier on Emacs 26+.

❤️ 4
h0bbit10:01:42

Off-topic, but can you please share why life is easier on Emacs 26+ :D . Context: I maintain pdf-tools, which currently supports Emacs all the way back to 24.3. This is causing problems for me and I plan to drop support for Emacs 24. org-mode policy is to support 3 major versions of Emacs (which would be 25, 26, 27 since 28 is not yet released). If there are good reasons to drop support for Emacs 25, I might as well do that in one-go as well :D

bozhidar11:01:39

Life is easier because we can use more newer APIs without resorting to hacks like the cider-compat.el that got deleted. 🙂 This simplifies the CI setup/speed as well. Our policy is to support whatever Emacs ships with RHEL and Debian Stable and for a while that has been Emacs 26.

bozhidar11:01:30

Also - Emacs 28 is going to be released pretty soon, so the 3 last releases will be 26, 27 & 28 anyways. 🙂

bozhidar11:01:04

Just check https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS.26 and look for * Lisp Changes in Emacs 26.1

bozhidar11:01:33

Nothing really major, but if almost no one uses Emacs 25 at this point, why not make our lives easier and the codebase better?

bozhidar11:01:05

Admittedly, my hand was also forced by some upstream deps of CIDER that dropped support for Emacs 25 (e.g. seq.el).

h0bbit04:01:50

Thanks, I'd love nothing more than to drop support for it, if only to simplify my life and CI setups :P . I'll review the NEWS as well as cider-compat files. I'm hoping Emacs 28 releases soon! 🤞

practicalli-john18:01:34

Proposed two minor changes to the way cider-clojure-cli-aliases is used. Happy to raise a PR if this seems okay https://github.com/clojure-emacs/cider/issues/3125

🙂 1
practicalli-john09:01:17

PR was raised with the changes and additional unit tests. Some of the checks are failing, but this seems to be due to things outside the scope of this change. Please let me know if there are further changes I should make to the PR. Thank you.

bozhidar10:01:41

Looks good. Thanks!